Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge XML report output #3491

Merged
merged 7 commits into from
Feb 24, 2021
Merged

Merge XML report output #3491

merged 7 commits into from
Feb 24, 2021

Conversation

chao2zhang
Copy link
Member

This is a rewrite of #3394 and addresses one item in #3360.

  • Only the gradle tasks are exposed: No opinionated way to configure the tasks.
  • Documentation is added.
  • Fix: utf-8 to UTF-8, because the latter is the standard.

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #3491 (130ce1b) into master (67dc147) will increase coverage by 0.44%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3491      +/-   ##
============================================
+ Coverage     80.06%   80.51%   +0.44%     
- Complexity     2864     2893      +29     
============================================
  Files           458      461       +3     
  Lines          8584     8668      +84     
  Branches       1663     1676      +13     
============================================
+ Hits           6873     6979     +106     
+ Misses          794      767      -27     
- Partials        917      922       +5     
Impacted Files Coverage Δ Complexity Δ
.../main/kotlin/io/gitlab/arturbosch/detekt/Detekt.kt 27.27% <ø> (ø) 20.00 <0.00> (ø)
...lab/arturbosch/detekt/report/XmlReportMergeTask.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...gitlab/arturbosch/detekt/report/XmlReportMerger.kt 90.47% <90.47%> (ø) 5.00 <5.00> (?)
...lin/io/github/detekt/report/xml/XmlOutputReport.kt 91.30% <100.00%> (ø) 7.00 <0.00> (ø)
...kt/rules/documentation/AbsentOrWrongFileLicense.kt 87.50% <0.00%> (-5.36%) 12.00% <0.00%> (+4.00%) ⬇️
.../arturbosch/detekt/internal/DetektMultiplatform.kt 90.90% <0.00%> (ø) 3.00% <0.00%> (?%)
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt 86.66% <0.00%> (+5.71%) 10.00% <0.00%> (+1.00%)
...ules/documentation/LicenceHeaderLoaderExtension.kt 80.95% <0.00%> (+9.07%) 6.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dc147...130ce1b. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this feature. I had a short look at it. It works fine. Great! 👍

I think it's good to start small with the XML report format. For me XML reports supporting a merge is the first logical step. Other reports could follow later on, if this is highly valuable.

I'm not sure regarding the test coverage for the XML parsing logic and task. Should we include more edge cases?

Co-authored-by: M Schalk <30376729+schalkms@users.noreply.github.com>
@chao2zhang
Copy link
Member Author

chao2zhang commented Feb 24, 2021

I really like this feature. I had a short look at it. It works fine. Great! 👍

I think it's good to start small with the XML report format. For me XML reports supporting a merge is the first logical step. Other reports could follow later on, if this is highly valuable.

I'm not sure regarding the test coverage for the XML parsing logic and task. Should we include more edge cases?

The logic is relatively straightforward so I think the existing test coverage should be fine and jacoco is happy about hitting the 80% coverage in this diff.

The overall project test coverage is increased, but the patch diff test coverage is lowered. We probably need to look into why it is giving us conflicting test coverage.

This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants