Skip to content

Fix SARIF validation failure#3507

Merged
schalkms merged 1 commit into
detekt:masterfrom
picklebento:sarif
Mar 1, 2021
Merged

Fix SARIF validation failure#3507
schalkms merged 1 commit into
detekt:masterfrom
picklebento:sarif

Conversation

@picklebento

Copy link
Copy Markdown
Member

When trying the relative output of SARIF report, the official validation tool yields the following failure:
WX20210228-232942

@codecov

codecov Bot commented Mar 1, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3507 (a328e5b) into master (c90eafe) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3507      +/-   ##
============================================
- Coverage     77.62%   77.61%   -0.02%     
  Complexity     2806     2806              
============================================
  Files           461      461              
  Lines          8672     8676       +4     
  Branches       1676     1678       +2     
============================================
+ Hits           6732     6734       +2     
  Misses         1035     1035              
- Partials        905      907       +2     
Impacted Files Coverage Δ Complexity Δ
...io/github/detekt/report/sarif/SarifOutputReport.kt 90.47% <40.00%> (-4.27%) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90eafe...3ef42af. Read the comment docs.

@BraisGabin BraisGabin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like SARIF babysits a lot.

@schalkms schalkms merged commit 7cf1ab3 into detekt:master Mar 1, 2021
@cortinico cortinico added this to the 1.16.0 milestone Mar 3, 2021
This was referenced Mar 11, 2021
@picklebento picklebento deleted the sarif branch March 11, 2021 16:38
This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants