-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle tweaks #3575
Gradle tweaks #3575
Conversation
d9bc6d7
to
6d318e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #3575 +/- ##
=========================================
Coverage 77.53% 77.53%
Complexity 2829 2829
=========================================
Files 464 464
Lines 8769 8769
Branches 1713 1713
=========================================
Hits 6799 6799
Misses 1046 1046
Partials 924 924 Continue to review full report at Codecov.
|
4f9fc1d
to
f1eeba7
Compare
* Prefer Maven Central to JCenter * Limit JCenter to kotlinx-html-jvm module only * Remove unnecessary repository declarations
There's no Java source code in the repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great refactor!
// We need to perform api validations for external APIs, for :detekt-api and :detekt-psi-utils | ||
ignoredProjects.addAll(subprojects.filter { it.name !in listOf("detekt-api", "detekt-psi-utils") }.map { it.name }) | ||
ignoredPackages.add("io.gitlab.arturbosch.detekt.api.internal") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
@@ -30,3 +31,7 @@ listOf(configurations.testFixturesApiElements, configurations.testFixturesRuntim | |||
tasks.withType<DokkaTask>().configureEach { | |||
outputDirectory.set(rootDir.resolve("docs/pages/kdoc")) | |||
} | |||
|
|||
apiValidation { | |||
ignoredPackages.add("io.gitlab.arturbosch.detekt.api.internal") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this necessary for detekt-psi-utils
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The io.gitlab.arturbosch.detekt.api.internal
package is only used in the detekt-api project so there shouldn't be any need to ignore it in detekt-psi-utils. :detekt-psi-utils:apiCheck
& :detekt-api:apiCheck
tasks both run successfully with this config.
Just rearranging a few things to make the build config a little more idiomatic, as well as fix a deprecation warning and fix a couple of issues in the README examples.