Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle tweaks #3575

Merged
merged 7 commits into from
Mar 20, 2021
Merged

Gradle tweaks #3575

merged 7 commits into from
Mar 20, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented Mar 19, 2021

Just rearranging a few things to make the build config a little more idiomatic, as well as fix a deprecation warning and fix a couple of issues in the README examples.

@3flex 3flex force-pushed the gradle-fixes branch 2 times, most recently from d9bc6d7 to 6d318e0 Compare March 19, 2021 12:39
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #3575 (3c4e5c3) into master (dde5fae) will not change coverage.
The diff coverage is n/a.

❗ Current head 3c4e5c3 differs from pull request most recent head 73a8f35. Consider uploading reports for the commit 73a8f35 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3575   +/-   ##
=========================================
  Coverage     77.53%   77.53%           
  Complexity     2829     2829           
=========================================
  Files           464      464           
  Lines          8769     8769           
  Branches       1713     1713           
=========================================
  Hits           6799     6799           
  Misses         1046     1046           
  Partials        924      924           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde5fae...73a8f35. Read the comment docs.

@3flex 3flex force-pushed the gradle-fixes branch 2 times, most recently from 4f9fc1d to f1eeba7 Compare March 19, 2021 12:57
Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great refactor!

// We need to perform api validations for external APIs, for :detekt-api and :detekt-psi-utils
ignoredProjects.addAll(subprojects.filter { it.name !in listOf("detekt-api", "detekt-psi-utils") }.map { it.name })
ignoredPackages.add("io.gitlab.arturbosch.detekt.api.internal")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@@ -30,3 +31,7 @@ listOf(configurations.testFixturesApiElements, configurations.testFixturesRuntim
tasks.withType<DokkaTask>().configureEach {
outputDirectory.set(rootDir.resolve("docs/pages/kdoc"))
}

apiValidation {
ignoredPackages.add("io.gitlab.arturbosch.detekt.api.internal")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this necessary for detekt-psi-utils as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The io.gitlab.arturbosch.detekt.api.internal package is only used in the detekt-api project so there shouldn't be any need to ignore it in detekt-psi-utils. :detekt-psi-utils:apiCheck & :detekt-api:apiCheck tasks both run successfully with this config.

@chao2zhang chao2zhang added this to the 1.16.1 milestone Mar 19, 2021
@BraisGabin BraisGabin merged commit 866eb2b into detekt:master Mar 20, 2021
@3flex 3flex deleted the gradle-fixes branch March 20, 2021 10:58
@chao2zhang chao2zhang modified the milestones: 1.16.1, 1.17.0 Mar 21, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label May 1, 2021
@3flex 3flex restored the gradle-fixes branch July 29, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants