New Rule: ObjectLiteralToLambda by zmunm · Pull Request #3599 · detekt/detekt

zmunm · 2021-03-23T14:00:06Z

I hope there isn't much I've missed.

…le-abstract-method

codecov · 2021-03-23T14:18:24Z

Codecov Report

Merging #3599 (fd9222a) into main (4495b36) will increase coverage by 0.02%.
The diff coverage is 78.41%.

❗ Current head fd9222a differs from pull request most recent head 14085ad. Consider uploading reports for the commit 14085ad to get more accurate results

@@             Coverage Diff              @@
##               main    #3599      +/-   ##
============================================
+ Coverage     77.97%   78.00%   +0.02%     
- Complexity     2837     2897      +60     
============================================
  Files           467      472       +5     
  Lines          9139     9306     +167     
  Branches       1737     1776      +39     
============================================
+ Hits           7126     7259     +133     
- Misses         1071     1077       +6     
- Partials        942      970      +28

Impacted Files	Coverage Δ	Complexity Δ
...t/generator/collection/RuleSetProviderCollector.kt	`75.47% <0.00%> (-1.89%)`	`4.00 <0.00> (ø)`
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt	`6.25% <ø> (+0.25%)`	`0.00 <0.00> (ø)`
...lab/arturbosch/detekt/internal/ClassLoaderCache.kt	`85.71% <ø> (ø)`	`0.00 <0.00> (ø)`
...o/gitlab/arturbosch/detekt/internal/DetektPlain.kt	`0.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...o/gitlab/arturbosch/detekt/internal/SharedTasks.kt	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...ekt/generator/collection/DocumentationCollector.kt	`70.00% <70.00%> (ø)`	`15.00 <15.00> (?)`
...ekt/generator/collection/ConfigurationCollector.kt	`70.58% <70.58%> (ø)`	`20.00 <20.00> (?)`
...b/arturbosch/detekt/api/internal/ConfigProperty.kt	`80.00% <80.00%> (ø)`	`0.00 <0.00> (?)`
...rbosch/detekt/rules/style/ObjectLiteralToLambda.kt	`81.25% <81.25%> (ø)`	`23.00 <23.00> (?)`
...detekt/rules/bugs/DoubleMutabilityForCollection.kt	`88.46% <88.46%> (ø)`	`4.00 <4.00> (?)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4495b36...14085ad. Read the comment docs.

BraisGabin · 2021-03-23T14:24:17Z

+ * }
+ * </compliant>
+ *
+ * @active since v1.17.0


Don't activate it by default please.

Thank you. Are there any criteria to set the rule to be enabled by default?

We never enable a rule by default the first time we introduced it because it can have false positives and we will impact to a lot of users. We prefer to enable it later if we think that its a rule that nearly all our user base will like to have it. But we don't have any defined rule here.

cortinico

Nice test coverage 👍

picklebento · 2021-03-24T14:15:32Z

+        Debt.FIVE_MINS
+    )
+
+    private val KotlinType.isSamInterface


Suggested change

private val KotlinType.isSamInterface

private val KotlinType.couldBeSamInterface

According to its original documentation, isDefinitelyNotSamInterface may return falsely false

picklebento · 2021-03-24T14:18:15Z

+ * An anonymous object that does nothing other than the implementation of a single method
+ * can be used as a lambda.
+ *
+ * See https://kotlinlang.org/docs/fun-interfaces.html


Would this rule detect findings when the consuming code is Kotlin 1.3 or 1.3-?

(It may be good at least to call it out in the documentation)

I wandering looking for a way to test. Can you give me a hint? @chao2zhang

I believe this requires us to set up a sample project and set its kotlin version to 1.3.*

When running detektMain with java.util.Runnable in 1.3.72, it was confirmed that it is detected as a test case.

Couldn't we get that information from CompilerResources?

About how to test that if... we don't have any way to make it right now. But maybe we can create an issue to fix that and accept that if untested for now.

Everything is new, so I'm grasping it. :loading:
Please let me know if you have any misunderstandings.

From what I checked, in CompileResource, We can only see that the version is 1.3, and it seems that We can't actually compile with 1.3. Is that right?

What we want to check is the latter, and in java-interop there is nothing we can do with LanguageVersion.KOTLIN_1_3 because the code we need to detect is exactly the same.

When I tested fun interface in 1.3, there is nothing else to do because it fails in the :compileKotlin task.

If I make an issue, I think I will have to rewrite the case in the module implementing 1.3, but I wonder if this falls within the scope of the project's support.

The bottom line is that we do not crash when compiling Kotlin 1.3.
What's better is that even if the code does not compile, detekt findings should be easy to understand.

Currently, the default configured detekt task does not depend on compileKotlin. If the error message is confusing, we should consider adding a LanguageVersion.KOTLIN_1_3 version check, otherwise, this PR should be good to go.

picklebento · 2021-03-25T06:07:02Z

Actually, I also find that converting to SAM may indicate anonymous object converted to singleton: JetBrains/kotlin@99a6bde

I guess this is an edge case but we should at least call it out. (We can soon have @Controverial annotation)

zmunm · 2021-03-29T11:27:28Z

In the process of adding the case, there have been many modifications to the code and JetBrains/kotlin@99a6bde is still under research.
So I changed PR to a draft and I'll request again as soon as it is resolved. Thank you

BraisGabin · 2021-04-07T18:20:24Z

+ * An anonymous object that does nothing other than the implementation of a single method
+ * can be used as a lambda.
+ *
+ * See https://kotlinlang.org/docs/fun-interfaces.html


Couldn't we get that information from CompilerResources?

About how to test that if... we don't have any way to make it right now. But maybe we can create an issue to fix that and accept that if untested for now.

…/rules/style/ObjectLiteralToLambdaSpec.kt

zmunm · 2021-04-12T01:12:21Z

@chao2zhang Please change the linked issue to #3528

picklebento · 2021-04-14T16:07:58Z

Should Detekt support primarily the current and the immediate previous feature release?
As Kotlin 1.5 is approaching, adding checks for Kotlin 1.4 language features should be okay to merge and we can loose our compatibility requirement for Kotlin 1.3-.

zmunm · 2021-05-12T03:20:04Z

Is there something else I need to add for this?

picklebento · 2021-05-12T03:42:36Z

Kotlin 1.5 has arrived already (Not in Detekt yet), we could say that Detekt at maximum will be supporting 2 major releases of Kotlin.

zmunm added 12 commits March 17, 2021 23:08

Add single abstract method rule

807537b

Add default config

a9cc55b

Add document link

71e6d74

Modify existing file

b07e173

Add single abstract method rule

e19b253

Add default config

c0b392a

Add document link

52844dd

Modify existing file

d99fab4

Merge remote-tracking branch 'zmunm/single-abstract-method' into sing…

427b4ea

…le-abstract-method

Merge branch 'master' into single-abstract-method

ccd2fd0

Modify with descriptor verification

8970c8b

Add java case

e22051e

BraisGabin reviewed Mar 23, 2021

View reviewed changes

zmunm added 3 commits March 24, 2021 01:50

Fix default active false

bbded7e

Fix to compilable snippet

035c41b

Remove inaccessible branches

c26e5b1

BraisGabin approved these changes Mar 23, 2021

View reviewed changes

cortinico reviewed Mar 23, 2021

View reviewed changes

Comment thread ...rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/ObjectLiteralToLambda.kt

zmunm added 2 commits March 24, 2021 12:10

Merge branch 'main' into single-abstract-method

05da0b7

Add requiresTypeResolution

ba9defe

zmunm requested a review from cortinico March 24, 2021 04:00

picklebento reviewed Mar 24, 2021

View reviewed changes

picklebento added the rules label Mar 25, 2021

picklebento linked an issue Mar 27, 2021 that may be closed by this pull request

New rule: interfaces with single abstract method prefixed with fun #3529

Open

zmunm added 2 commits March 29, 2021 14:04

Merge branch 'main' into single-abstract-method

51bf9a0

Add case when object use itself

384e2de

zmunm marked this pull request as draft March 29, 2021 11:14

zmunm added 3 commits March 29, 2021 20:38

Fix import ordering

edb576a

Fix UnsafeCallOnNullableType

48da6a8

Add reference edge case

8c5a765

zmunm commented Mar 29, 2021

View reviewed changes

Comment thread ...s-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/ObjectLiteralToLambdaSpec.kt

zmunm added 2 commits April 1, 2021 01:45

Merge remote-tracking branch 'detekt/main' into single-abstract-method

fc1c882

Merge remote-tracking branch 'detekt/main' into single-abstract-method

ad7d2cc

zmunm marked this pull request as ready for review April 7, 2021 14:04

zmunm requested review from BraisGabin and picklebento April 7, 2021 14:05

BraisGabin approved these changes Apr 7, 2021

View reviewed changes

picklebento approved these changes Apr 11, 2021

View reviewed changes

picklebento added this to the 1.17.0 milestone Apr 11, 2021

Update detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt…

72d3926

…/rules/style/ObjectLiteralToLambdaSpec.kt

picklebento approved these changes Apr 12, 2021

View reviewed changes

Comment thread ...s-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/ObjectLiteralToLambdaSpec.kt Outdated

Comment thread ...s-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/ObjectLiteralToLambdaSpec.kt Outdated

Chao Zhang added 2 commits April 11, 2021 17:33

Update detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt…

96c885a

…/rules/style/ObjectLiteralToLambdaSpec.kt

Update detekt-rules-style/src/test/kotlin/io/gitlab/arturbosch/detekt…

14085ad

…/rules/style/ObjectLiteralToLambdaSpec.kt

picklebento linked an issue Apr 12, 2021 that may be closed by this pull request

suggest Single Abstract Method #3528

Closed

picklebento removed a link to an issue Apr 12, 2021

New rule: interfaces with single abstract method prefixed with fun #3529

Open

picklebento merged commit 4d80329 into detekt:main May 12, 2021

zmunm deleted the single-abstract-method branch May 12, 2021 03:44

zmunm mentioned this pull request May 12, 2021

Update contributor list #3763

Merged

picklebento pushed a commit to picklebento/detekt that referenced this pull request May 13, 2021

New Rule: ObjectLiteralToLambda (detekt#3599)

5f28efc

	private val KotlinType.isSamInterface
	private val KotlinType.couldBeSamInterface

Uh oh!

Conversation

zmunm commented Mar 23, 2021

Uh oh!

codecov Bot commented Mar 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cortinico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

picklebento commented Mar 25, 2021

Uh oh!

zmunm commented Mar 29, 2021

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zmunm commented Apr 12, 2021

Uh oh!

picklebento commented Apr 14, 2021

Uh oh!

zmunm commented May 12, 2021

Uh oh!

picklebento commented May 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Mar 23, 2021 •

edited

Loading