Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing IllegalArgumentException in ForbiddenMethodCall rule for Intersection type parameters #3626

Merged

Conversation

DcortezMeleth
Copy link
Contributor

…section type parameters

PR fixing issue reported in #3546.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #3626 (a296d5e) into main (3335280) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a296d5e differs from pull request most recent head 17cc26d. Consider uploading reports for the commit 17cc26d to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3626   +/-   ##
=========================================
  Coverage     78.17%   78.17%           
  Complexity     2836     2836           
=========================================
  Files           467      467           
  Lines          9139     9139           
  Branches       1733     1733           
=========================================
  Hits           7144     7144           
  Misses         1057     1057           
  Partials        938      938           
Impacted Files Coverage Δ Complexity Δ
...turbosch/detekt/rules/style/ForbiddenMethodCall.kt 89.18% <100.00%> (ø) 14.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3335280...17cc26d. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me!

@DcortezMeleth
Copy link
Contributor Author

@schalkms Do you maybe know why one of the check failed?
I have looked at it but unfortunately I don't understand how may change may have caused this failure.

@BraisGabin
Copy link
Member

BraisGabin commented Mar 30, 2021

@schalkms Do you maybe know why one of the check failed?
I have looked at it but unfortunately I don't understand how may change may have caused this failure.

Don't worry about it. This issue is in the main branch, it's not in yours.

I'm not so sure about this now, but for sure it not related with your chage so don't worry. We will merge it as soon as you can handle the conflicts 👍

@DcortezMeleth
Copy link
Contributor Author

Thanks for the information. :)
Branch should be up to date now.

@BraisGabin BraisGabin merged commit 90d250c into detekt:main Mar 31, 2021
@cortinico cortinico added this to the 1.17.0 milestone Apr 12, 2021
@cortinico cortinico changed the title Fixing IllegalArgumentException in ForbiddenMethodCall rule for Inter… Fixing IllegalArgumentException in ForbiddenMethodCall rule for Intersection type parameters May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants