Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support to Gradle 5 #3647

Closed
wants to merge 1 commit into from
Closed

Drop support to Gradle 5 #3647

wants to merge 1 commit into from

Conversation

BraisGabin
Copy link
Member

Drop support to gradle 5.

5.0 was release at 16/Apr/2019. This moves the support 6.0. It was release at 08/Nov/2019. Maybe we coud be even more aggresive here but I think that 6.0 is a safe commitment.

As a reference the Gradle Android Plugin set the minimum gradle version to 6.1 at April 2020. And the last version of the AGP requires Gradle 6.5

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #3647 (e348745) into main (1c140c8) will not change coverage.
The diff coverage is n/a.

❗ Current head e348745 differs from pull request most recent head 080984d. Consider uploading reports for the commit 080984d to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3647   +/-   ##
=========================================
  Coverage     78.12%   78.12%           
  Complexity     2836     2836           
=========================================
  Files           467      467           
  Lines          9142     9142           
  Branches       1737     1737           
=========================================
  Hits           7142     7142           
  Misses         1058     1058           
  Partials        942      942           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c140c8...080984d. Read the comment docs.

@chao2zhang chao2zhang added this to the 1.17.0 milestone Apr 3, 2021
Copy link
Member

@3flex 3flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlin's current minimum supported Gradle version is 5.4. Why not keep the versions aligned? Increasing the minimum now seems arbitrary.

That said, I believe Kotlin 1.5 will bump the minimum supported version to 6.1 so when that's released and detekt updates to 1.5 I'd support an update to 6.1.

@BraisGabin
Copy link
Member Author

Good reason! Yes, let's keep us aligned with the Kotlin Gradle Plugin.

@BraisGabin BraisGabin closed this Apr 3, 2021
@BraisGabin BraisGabin deleted the drop-support-gradle-5 branch April 21, 2021 12:31
@BraisGabin
Copy link
Member Author

That said, I believe Kotlin 1.5 will bump the minimum supported version to 6.1 so when that's released and detekt updates to 1.5 I'd support an update to 6.1.

I can not find anywhere about this bump of the minimum version. Do this happen?

@3flex
Copy link
Member

3flex commented May 23, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants