Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add src/test/java and src/test/kotlin by default in PlainDetekt #3649

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

BraisGabin
Copy link
Member

We aren't adding the source sets src/test/java and src/test/kotlin in the PlainDetekt. It have little sense that we don't add those by default because our default configuration take those sources into account.

@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #3649 (b59ba33) into main (1c140c8) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head b59ba33 differs from pull request most recent head 2f6116b. Consider uploading reports for the commit 2f6116b to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3649      +/-   ##
============================================
- Coverage     78.12%   78.08%   -0.04%     
  Complexity     2836     2836              
============================================
  Files           467      467              
  Lines          9142     9146       +4     
  Branches       1737     1737              
============================================
  Hits           7142     7142              
- Misses         1058     1062       +4     
  Partials        942      942              
Impacted Files Coverage Δ Complexity Δ
...ab/arturbosch/detekt/extensions/DetektExtension.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c140c8...2f6116b. Read the comment docs.

@chao2zhang
Copy link
Member

It have little sense that we don't add those by default because our default configuration take those sources into account.

Agree 👍

@chao2zhang chao2zhang added this to the 1.17.0 milestone Apr 4, 2021
@chao2zhang chao2zhang merged commit 4495b36 into main Apr 7, 2021
@chao2zhang chao2zhang deleted the test-src-as-default branch April 7, 2021 01:02
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Apr 7, 2021
@cortinico
Copy link
Member

This is something we want to mention specifically in the changelog right? I expect users that are using the default config to get a lot of violation for their tests: #3102 (comment)

@BraisGabin BraisGabin removed the housekeeping Marker for housekeeping tasks and refactorings label Apr 27, 2021
@BraisGabin
Copy link
Member Author

Agree, this is not housekeeping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants