Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamedArguments rule: fix false positive with trailing lambda #3661

Merged
merged 3 commits into from
Apr 11, 2021

Conversation

t-kameyama
Copy link
Contributor

Fixes #3658

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #3661 (c12e0d7) into main (cff4f55) will decrease coverage by 0.01%.
The diff coverage is 75.50%.

❗ Current head c12e0d7 differs from pull request most recent head e03a354. Consider uploading reports for the commit e03a354 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3661      +/-   ##
============================================
- Coverage     78.00%   77.98%   -0.02%     
- Complexity     2837     2874      +37     
============================================
  Files           467      471       +4     
  Lines          9135     9273     +138     
  Branches       1737     1764      +27     
============================================
+ Hits           7126     7232     +106     
- Misses         1067     1077      +10     
- Partials        942      964      +22     
Impacted Files Coverage Δ Complexity Δ
...t/generator/collection/RuleSetProviderCollector.kt 75.47% <0.00%> (-1.89%) 4.00 <0.00> (ø)
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt 6.25% <ø> (+0.25%) 0.00 <0.00> (ø)
...ab/arturbosch/detekt/extensions/DetektExtension.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...o/gitlab/arturbosch/detekt/internal/DetektPlain.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...o/gitlab/arturbosch/detekt/internal/SharedTasks.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ekt/generator/collection/DocumentationCollector.kt 70.00% <70.00%> (ø) 15.00 <15.00> (?)
...ekt/generator/collection/ConfigurationCollector.kt 70.58% <70.58%> (ø) 20.00 <20.00> (?)
...b/arturbosch/detekt/api/internal/ConfigProperty.kt 80.00% <80.00%> (ø) 0.00 <0.00> (?)
...detekt/rules/bugs/DoubleMutabilityForCollection.kt 88.46% <88.46%> (ø) 4.00 <4.00> (?)
...urbosch/detekt/generator/collection/Annotations.kt 71.42% <100.00%> (+16.88%) 0.00 <0.00> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff4f55...e03a354. Read the comment docs.

@chao2zhang chao2zhang added this to the 1.17.0 milestone Apr 11, 2021
@chao2zhang chao2zhang merged commit 3fb459c into detekt:main Apr 11, 2021
@t-kameyama t-kameyama deleted the issue_3658 branch April 11, 2021 21:05
chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NamedArguments rule: false positive with trailing lambda
4 participants