Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UnusedPrivateMemberSpec #3667

Merged
merged 1 commit into from
Apr 10, 2021
Merged

Refactor UnusedPrivateMemberSpec #3667

merged 1 commit into from
Apr 10, 2021

Conversation

chao2zhang
Copy link
Member

@chao2zhang chao2zhang commented Apr 9, 2021

This is a preparation PR for #3418 to

  • Refactor off UnusedPrivateMemberNegative.kt and UnusedPrivateMemberPositive.kt
  • Extracted tests related to parameters into UnusedPrivateParameterSpec.kt

With smaller modularized unit tests, it would be easy to review future PRs.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #3667 (8964043) into main (2c4b6fb) will not change coverage.
The diff coverage is n/a.

❗ Current head 8964043 differs from pull request most recent head a183598. Consider uploading reports for the commit a183598 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3667   +/-   ##
=========================================
  Coverage     77.95%   77.95%           
  Complexity     2870     2870           
=========================================
  Files           470      470           
  Lines          9245     9245           
  Branches       1761     1761           
=========================================
  Hits           7207     7207           
  Misses         1077     1077           
  Partials        961      961           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4b6fb...a183598. Read the comment docs.

@chao2zhang chao2zhang added this to the 1.17.0 milestone Apr 10, 2021
@chao2zhang chao2zhang merged commit e9fd9f3 into detekt:main Apr 10, 2021
@chao2zhang chao2zhang deleted the member branch April 10, 2021 16:22
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label May 1, 2021
chao2zhang added a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants