Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to setup-java@v2 #3704

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Update to setup-java@v2 #3704

merged 1 commit into from
Apr 26, 2021

Conversation

3flex
Copy link
Member

@3flex 3flex commented Apr 26, 2021

  • Use AdoptJDK distribution which is the distribution cached on runners
  • Use LTS version of Java for generated config file verification & test snippet compilation tasks

* Use AdoptJDK distribution which is the distribution cached on runners
* Use LTS version of Java for generated config file verification & test snippet compilation tasks
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #3704 (c400b63) into main (1249b22) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3704   +/-   ##
=========================================
  Coverage     78.04%   78.04%           
  Complexity     2883     2883           
=========================================
  Files           473      473           
  Lines          9302     9302           
  Branches       1767     1767           
=========================================
  Hits           7260     7260           
  Misses         1078     1078           
  Partials        964      964           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1249b22...c400b63. Read the comment docs.

@BraisGabin BraisGabin merged commit 20bc74c into main Apr 26, 2021
@BraisGabin BraisGabin deleted the setup-java-v2 branch April 26, 2021 18:36
3flex added a commit that referenced this pull request Apr 30, 2021
3flex added a commit that referenced this pull request May 1, 2021
@cortinico cortinico added this to the 1.17.0 milestone May 1, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label May 1, 2021
3flex added a commit that referenced this pull request May 1, 2021
3flex added a commit that referenced this pull request May 1, 2021
3flex added a commit that referenced this pull request May 2, 2021
chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
* Use AdoptJDK distribution which is the distribution cached on runners
* Use LTS version of Java for generated config file verification & test snippet compilation tasks
3flex added a commit that referenced this pull request Oct 1, 2021
3flex added a commit that referenced this pull request Oct 12, 2021
3flex added a commit to 3flex/detekt that referenced this pull request Oct 21, 2021
3flex added a commit that referenced this pull request Oct 21, 2021
* Update to setup-java@v2

Missed in #3704

* Use consistent file encoding across builds

This changes to use the recommended config from
https://docs.gradle.org/7.0/userguide/common_caching_problems.html#system_file_encoding

* Don't disable build cache when generating JaCoCo merged report

* Don't set JDK_VERSION env var

This is unnecessary as it isn't used anywhere in the build.

* Remove redundant setup-java action from FOSSA scan workflow

* Ignore the whole FOSSA scan workflow in forks

This ignores the whole job instead of just the fossa-scan action, since we
don't need to run any part of the job in forks of detekt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants