Merged
Conversation
Member
3flex
commented
Apr 26, 2021
3flex
commented
- Use AdoptJDK distribution which is the distribution cached on runners
- Use LTS version of Java for generated config file verification & test snippet compilation tasks
* Use AdoptJDK distribution which is the distribution cached on runners * Use LTS version of Java for generated config file verification & test snippet compilation tasks
Codecov Report
@@ Coverage Diff @@
## main #3704 +/- ##
=========================================
Coverage 78.04% 78.04%
Complexity 2883 2883
=========================================
Files 473 473
Lines 9302 9302
Branches 1767 1767
=========================================
Hits 7260 7260
Misses 1078 1078
Partials 964 964 Continue to review full report at Codecov.
|
picklebento
approved these changes
Apr 26, 2021
BraisGabin
approved these changes
Apr 26, 2021
picklebento
pushed a commit
to picklebento/detekt
that referenced
this pull request
May 13, 2021
* Use AdoptJDK distribution which is the distribution cached on runners * Use LTS version of Java for generated config file verification & test snippet compilation tasks
3flex
added a commit
to 3flex/detekt
that referenced
this pull request
Oct 21, 2021
Missed in detekt#3704
3flex
added a commit
that referenced
this pull request
Oct 21, 2021
* Update to setup-java@v2 Missed in #3704 * Use consistent file encoding across builds This changes to use the recommended config from https://docs.gradle.org/7.0/userguide/common_caching_problems.html#system_file_encoding * Don't disable build cache when generating JaCoCo merged report * Don't set JDK_VERSION env var This is unnecessary as it isn't used anywhere in the build. * Remove redundant setup-java action from FOSSA scan workflow * Ignore the whole FOSSA scan workflow in forks This ignores the whole job instead of just the fossa-scan action, since we don't need to run any part of the job in forks of detekt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.