-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We have a logo :) #3726
We have a logo :) #3726
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3726 +/- ##
=========================================
Coverage 78.04% 78.04%
Complexity 2883 2883
=========================================
Files 473 473
Lines 9300 9300
Branches 1767 1767
=========================================
Hits 7258 7258
Misses 1078 1078
Partials 964 964 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should unify the appearance of detekt and use the same logo wherever possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should highlight this in our changelog, right?
It's ok to store them in the repo as they're SVG 👌
Maybe we can create a logo with some background to make it render good in both themes?
+1 for Purple
<3
Yup, I believe this can be on the spotlight for 1.17.0 🎉 |
I think we would need a background layer (thats how most of the repo logos are designed) or we could choose a color that works on both themes (coil is a good example). Maybe in the future it is also possible to dynamically react to the current theme: Support theme context for images in light vs dark mode |
I removed the orange ones 👍 |
I added the svg to the project inside the folder media (should we upload them in other place instead?)
I added changed the favicon (thanks @JavierSegoviaCordoba). I used the purple one. as I can read here svg is supported in the last version of all major browsers so I think it's better to not use
.ico
.I added the logo in the index of our home page. I used the purple with the name.
I didn't add the logo in the readme because the version with "detekt" on ti doesn't work well on dark mode.
I didn't updated the social media image (thanks @G00fY2) nor the organization image because I'm not 100% sure if we all agree about the purple one. To be honest I like them both. The purple reminds me more to kotlin but the orange feels more like "warning".
And, once we decide if we prefer purple or organe should I remove the other color from
/media
?And, of course! Thanks again @payathedo for the logos! :)