Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We have a logo :) #3726

Merged
merged 5 commits into from
May 4, 2021
Merged

We have a logo :) #3726

merged 5 commits into from
May 4, 2021

Conversation

BraisGabin
Copy link
Member

@BraisGabin BraisGabin commented Apr 30, 2021

I added the svg to the project inside the folder media (should we upload them in other place instead?)

I added changed the favicon (thanks @JavierSegoviaCordoba). I used the purple one. as I can read here svg is supported in the last version of all major browsers so I think it's better to not use .ico.

I added the logo in the index of our home page. I used the purple with the name.

I didn't add the logo in the readme because the version with "detekt" on ti doesn't work well on dark mode.

I didn't updated the social media image (thanks @G00fY2) nor the organization image because I'm not 100% sure if we all agree about the purple one. To be honest I like them both. The purple reminds me more to kotlin but the orange feels more like "warning".

And, once we decide if we prefer purple or organe should I remove the other color from /media?

And, of course! Thanks again @payathedo for the logos! :)

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #3726 (6df6c8a) into main (f290bf7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3726   +/-   ##
=========================================
  Coverage     78.04%   78.04%           
  Complexity     2883     2883           
=========================================
  Files           473      473           
  Lines          9300     9300           
  Branches       1767     1767           
=========================================
  Hits           7258     7258           
  Misses         1078     1078           
  Partials        964      964           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f290bf7...6df6c8a. Read the comment docs.

Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should unify the appearance of detekt and use the same logo wherever possible.

Copy link
Member

@chao2zhang chao2zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should highlight this in our changelog, right?

@cortinico
Copy link
Member

It's ok to store them in the repo as they're SVG 👌

I didn't add the logo in the readme because the version with "detekt" on ti doesn't work well on dark mode.

Maybe we can create a logo with some background to make it render good in both themes?

I didn't updated the social media image (thanks @G00fY2) nor the organization image because I'm not 100% sure if we all agree about the purple one. To be honest I like them both. The purple reminds me more to kotlin but the orange feels more like "warning".
And, once we decide if we prefer purple or organe should I remove the other color from /media?

+1 for Purple

And, of course! Thanks again @payathedo for the logos! :)

<3

We should highlight this in our changelog, right?

Yup, I believe this can be on the spotlight for 1.17.0 🎉

@G00fY2
Copy link
Contributor

G00fY2 commented May 2, 2021

I didn't add the logo in the readme because the version with "detekt" on ti doesn't work well on dark mode.

Maybe we can create a logo with some background to make it render good in both themes?

I think we would need a background layer (thats how most of the repo logos are designed) or we could choose a color that works on both themes (coil is a good example).

Maybe in the future it is also possible to dynamically react to the current theme: Support theme context for images in light vs dark mode

@chao2zhang chao2zhang linked an issue May 2, 2021 that may be closed by this pull request
@chao2zhang chao2zhang added this to the 1.17.0 milestone May 2, 2021
@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label May 3, 2021
@BraisGabin
Copy link
Member Author

I think we should unify the appearance of detekt and use the same logo wherever possible.

I removed the orange ones 👍

@chao2zhang chao2zhang merged commit acfeea1 into main May 4, 2021
@chao2zhang chao2zhang deleted the logo branch May 4, 2021 18:13
@cortinico cortinico added documentation and removed housekeeping Marker for housekeeping tasks and refactorings labels May 12, 2021
chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get detekt a logo
5 participants