Skip to content

Properly populate versions.properties#3730

Merged
picklebento merged 3 commits into
detekt:mainfrom
cortinico:nc/fix-versions.properties
May 2, 2021
Merged

Properly populate versions.properties#3730
picklebento merged 3 commits into
detekt:mainfrom
cortinico:nc/fix-versions.properties

Conversation

@cortinico

Copy link
Copy Markdown
Member

Detekt 1.17.0-RC1 was bundled with a versions.properties that contains just 1.17.0.
This PR fixes this problem using the expand() function of CopySpec. I'm not sure how to write a test for this, but I verified on my Maven Local and the file is populated correctly with 1.17.0-RC1

Fixes #3729

@3flex

3flex commented May 2, 2021

Copy link
Copy Markdown
Member

There's a WriteProperties task type that might work better instead (I haven't tried): https://docs.gradle.org/current/javadoc/org/gradle/api/tasks/WriteProperties.html

Want to look at that here as an alternative? Or this could be merged first then I can take a look at that sometime.

@cortinico

Copy link
Copy Markdown
Member Author

Want to look at that here as an alternative? Or this could be merged first then I can take a look at that sometime.

Thanks for the hint. I've implemented it in f66dc92 and I believe is much nicer that the other approach.

@codecov

codecov Bot commented May 2, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3730 (81f3133) into main (50b453b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3730   +/-   ##
=========================================
  Coverage     78.04%   78.04%           
  Complexity     2883     2883           
=========================================
  Files           473      473           
  Lines          9300     9300           
  Branches       1767     1767           
=========================================
  Hits           7258     7258           
  Misses         1078     1078           
  Partials        964      964           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b453b...81f3133. Read the comment docs.

@picklebento
picklebento merged commit 9dc55c2 into detekt:main May 2, 2021
@picklebento picklebento added this to the 1.17.0 milestone May 2, 2021
picklebento pushed a commit to picklebento/detekt that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detekt 1.17.0-RC1 does not work

4 participants