Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly populate versions.properties #3730

Merged
merged 3 commits into from
May 2, 2021

Conversation

cortinico
Copy link
Member

Detekt 1.17.0-RC1 was bundled with a versions.properties that contains just 1.17.0.
This PR fixes this problem using the expand() function of CopySpec. I'm not sure how to write a test for this, but I verified on my Maven Local and the file is populated correctly with 1.17.0-RC1

Fixes #3729

@3flex
Copy link
Member

3flex commented May 2, 2021

There's a WriteProperties task type that might work better instead (I haven't tried): https://docs.gradle.org/current/javadoc/org/gradle/api/tasks/WriteProperties.html

Want to look at that here as an alternative? Or this could be merged first then I can take a look at that sometime.

@cortinico
Copy link
Member Author

Want to look at that here as an alternative? Or this could be merged first then I can take a look at that sometime.

Thanks for the hint. I've implemented it in f66dc92 and I believe is much nicer that the other approach.

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #3730 (81f3133) into main (50b453b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3730   +/-   ##
=========================================
  Coverage     78.04%   78.04%           
  Complexity     2883     2883           
=========================================
  Files           473      473           
  Lines          9300     9300           
  Branches       1767     1767           
=========================================
  Hits           7258     7258           
  Misses         1078     1078           
  Partials        964      964           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b453b...81f3133. Read the comment docs.

@chao2zhang chao2zhang merged commit 9dc55c2 into detekt:main May 2, 2021
@chao2zhang chao2zhang added this to the 1.17.0 milestone May 2, 2021
chao2zhang pushed a commit to chao2zhang/detekt that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detekt 1.17.0-RC1 does not work
4 participants