Check bindingContext only once in MemberNameEqualsClassName#3899
Merged
BraisGabin merged 2 commits intodetekt:mainfrom Jun 25, 2021
schalkms:bindingContext-check
Merged
Check bindingContext only once in MemberNameEqualsClassName#3899BraisGabin merged 2 commits intodetekt:mainfrom schalkms:bindingContext-check
BraisGabin merged 2 commits intodetekt:mainfrom
schalkms:bindingContext-check
Conversation
This change simplifies the MemberNameEqualsClassName rule. For a class/function pair the bindingContext check happens once.
Codecov Report
@@ Coverage Diff @@
## main #3899 +/- ##
=========================================
Coverage 83.54% 83.55%
+ Complexity 3119 3118 -1
=========================================
Files 456 456
Lines 8974 8973 -1
Branches 1746 1746
=========================================
Hits 7497 7497
+ Misses 565 564 -1
Partials 912 912
Continue to review full report at Codecov.
|
picklebento
approved these changes
Jun 24, 2021
cortinico
approved these changes
Jun 25, 2021
BraisGabin
approved these changes
Jun 25, 2021
cortinico
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simplifies the MemberNameEqualsClassName rule.
For a class/function pair the bindingContext check happens once.