Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check bindingContext only once in MemberNameEqualsClassName #3899

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Check bindingContext only once in MemberNameEqualsClassName #3899

merged 2 commits into from
Jun 25, 2021

Conversation

schalkms
Copy link
Member

This change simplifies the MemberNameEqualsClassName rule.
For a class/function pair the bindingContext check happens once.

This change simplifies the MemberNameEqualsClassName rule.
For a class/function pair the bindingContext check happens once.
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #3899 (44534f9) into main (703487e) will increase coverage by 0.00%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3899   +/-   ##
=========================================
  Coverage     83.54%   83.55%           
+ Complexity     3119     3118    -1     
=========================================
  Files           456      456           
  Lines          8974     8973    -1     
  Branches       1746     1746           
=========================================
  Hits           7497     7497           
+ Misses          565      564    -1     
  Partials        912      912           
Impacted Files Coverage Δ
...h/detekt/rules/naming/MemberNameEqualsClassName.kt 84.21% <40.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703487e...44534f9. Read the comment docs.

@cortinico cortinico added this to the 1.18.0 milestone Jun 25, 2021
@BraisGabin BraisGabin merged commit 66f20e7 into detekt:main Jun 25, 2021
@cortinico cortinico changed the title Check bindingContext only once Check bindingContext only once in MemberNameEqualsClassName Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants