Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kotlin to v1.5.20 #3921

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Bump Kotlin to v1.5.20 #3921

merged 1 commit into from
Jun 30, 2021

Conversation

schalkms
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #3921 (dfd2f31) into main (3056e06) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3921      +/-   ##
============================================
- Coverage     83.59%   83.46%   -0.14%     
- Complexity     3123     3149      +26     
============================================
  Files           456      456              
  Lines          9015     9015              
  Branches       1754     1756       +2     
============================================
- Hits           7536     7524      -12     
- Misses          564      565       +1     
- Partials        915      926      +11     
Impacted Files Coverage Δ
...ab/arturbosch/detekt/rules/bugs/MissingWhenCase.kt 88.00% <ø> (ø)
...sch/detekt/rules/coroutines/SleepInsteadOfDelay.kt 72.00% <0.00%> (-8.00%) ⬇️
...arturbosch/detekt/generator/collection/KDocTags.kt 62.50% <0.00%> (-5.00%) ⬇️
...h/detekt/rules/style/DataClassContainsFunctions.kt 95.00% <0.00%> (-5.00%) ⬇️
...rturbosch/detekt/rules/bugs/UnnecessarySafeCall.kt 73.91% <0.00%> (-4.35%) ⬇️
...io/github/detekt/report/sarif/SarifOutputReport.kt 90.90% <0.00%> (-3.04%) ⬇️
...rturbosch/detekt/rules/style/UnusedPrivateClass.kt 70.66% <0.00%> (-2.67%) ⬇️
...ekt/generator/collection/DocumentationCollector.kt 85.00% <0.00%> (-2.50%) ⬇️
...t/rules/style/UtilityClassWithPublicConstructor.kt 93.61% <0.00%> (-2.13%) ⬇️
...ain/kotlin/io/gitlab/arturbosch/detekt/cli/Spec.kt 88.23% <0.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3056e06...dfd2f31. Read the comment docs.

@BraisGabin BraisGabin merged commit 7f2a478 into detekt:main Jun 30, 2021
@cortinico cortinico added this to the 1.18.0 milestone Jun 30, 2021
@cortinico cortinico added the dependencies Pull requests that update a dependency file label Jun 30, 2021
@cortinico
Copy link
Member

Just a small heads up: this bump is blocking a new release.
Specifically calling gw publishToMavenLocal fails with:

Caused by: kotlin.KotlinNullPointerException
        at org.jetbrains.kotlin.gradle.plugin.mpp.MppDependencyRewritingUtilsKt.associateDependenciesWithActualModuleDependencies(mppDependencyRewritingUtils.kt:188)
        at org.jetbrains.kotlin.gradle.plugin.mpp.MppDependencyRewritingUtilsKt.access$associateDependenciesWithActualModuleDependencies(mppDependencyRewritingUtils.kt:1)
        at org.jetbrains.kotlin.gradle.plugin.mpp.PomDependenciesRewriter$dependenciesMappingForEachUsageContext$2.call(mppDependencyRewritingUtils.kt:40)
        at org.jetbrains.kotlin.gradle.plugin.mpp.PomDependenciesRewriter$dependenciesMappingForEachUsageContext$2.call(mppDependencyRewritingUtils.kt:37)
        at org.gradle.api.internal.provider.DefaultProvider.calculateOwnValue(DefaultProvider.java:66)
        at org.gradle.api.internal.provider.AbstractMinimalProvider.get(AbstractMinimalProvider.java:84)
        at org.jetbrains.kotlin.gradle.utils.ProviderApiUtilsKt.getValue(providerApiUtils.kt:18)
        at org.jetbrains.kotlin.gradle.plugin.mpp.PomDependenciesRewriter.getDependenciesMappingForEachUsageContext(mppDependencyRewritingUtils.kt:37)
        at org.jetbrains.kotlin.gradle.plugin.mpp.PomDependenciesRewriter.rewritePomMppDependenciesToActualTargetModules(mppDependencyRewritingUtils.kt:73)
        at org.jetbrains.kotlin.gradle.plugin.mpp.PomDependenciesRewriter.rewritePomMppDependenciesToActualTargetModules$default(mppDependencyRewritingUtils.kt:47)
        at org.jetbrains.kotlin.gradle.plugin.AbstractKotlinPlugin$rewritePom$1.execute(KotlinPlugin.kt:424)
        at org.jetbrains.kotlin.gradle.plugin.AbstractKotlinPlugin$rewritePom$1.execute(KotlinPlugin.kt:422)
        at org.gradle.api.internal.UserCodeAction.execute(UserCodeAction.java:39)
        ... 234 more

There is already an issue reported to YouTrack: https://youtrack.jetbrains.com/issue/KT-47444
Hopefully we will see a 1.5.21 soon.

@schalkms
Copy link
Member Author

schalkms commented Jul 1, 2021

Hopefully we will see a 1.5.21 soon.

Shall we leave or rollback this PR until a fix is released?

@cortinico
Copy link
Member

Shall we leave or rollback this PR until a fix is released?

Since this is blocking the release process, I'd suggest we:

  1. Revert this PR
  2. Craft a 1.18.0-RC without this PR
  3. Wait for 1.5.21 to release the 1.18.0 stable

According to https://youtrack.jetbrains.com/issue/KT-47444, 1.5.21 is supposed to be out in ~6 days.

cortinico added a commit that referenced this pull request Jul 7, 2021
schalkms pushed a commit that referenced this pull request Jul 7, 2021
@cortinico cortinico mentioned this pull request Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants