Don't specify Gradle Enterprise Gradle Plugin version #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3flex
force-pushed
the
ge-plugin
branch
2 times, most recently
from
185e993
to
a46f442
Compare
Checking if this is up to date is not as simple as it should be as the dependencyUpdates task doesn't identify when it's out of date, so manual checks have to be done. Removing the specific version means when the Gradle version is updated, a recent Gradle Enterprise Gradle Plugin version will come with it, without having to update it separately.
Codecov Report
@@ Coverage Diff @@
## main #4210 +/- ##
=========================================
Coverage 84.24% 84.24%
Complexity 3243 3243
=========================================
Files 468 468
Lines 10176 10176
Branches 1786 1786
=========================================
Hits 8573 8573
Misses 658 658
Partials 945 945 Continue to review full report at Codecov.
|
chao2zhang
approved these changes
Oct 30, 2021
schalkms
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if this is up to date is not as simple as it should be as the dependencyUpdates task doesn't identify when it's out of date, so manual checks have to be done.
Removing the specific version means when the Gradle version is updated, a recent Gradle Enterprise Gradle Plugin version will come with it, without having to update it separately.