Skip to content

Don't specify Gradle Enterprise Gradle Plugin version#4210

Merged
3flex merged 1 commit into
detekt:mainfrom
3flex:ge-plugin
Oct 30, 2021
Merged

Don't specify Gradle Enterprise Gradle Plugin version#4210
3flex merged 1 commit into
detekt:mainfrom
3flex:ge-plugin

Conversation

@3flex

@3flex 3flex commented Oct 30, 2021

Copy link
Copy Markdown
Member

Checking if this is up to date is not as simple as it should be as the dependencyUpdates task doesn't identify when it's out of date, so manual checks have to be done.

Removing the specific version means when the Gradle version is updated, a recent Gradle Enterprise Gradle Plugin version will come with it, without having to update it separately.

@3flex 3flex closed this Oct 30, 2021
@3flex 3flex reopened this Oct 30, 2021
@3flex
3flex force-pushed the ge-plugin branch 2 times, most recently from 185e993 to a46f442 Compare October 30, 2021 14:08
Checking if this is up to date is not as simple as it should be as the
dependencyUpdates task doesn't identify when it's out of date, so manual
checks have to be done.

Removing the specific version means when the Gradle version is updated,
a recent Gradle Enterprise Gradle Plugin version will come with it,
without having to update it separately.
@codecov

codecov Bot commented Oct 30, 2021

Copy link
Copy Markdown

Codecov Report

Merging #4210 (d466fe6) into main (dd61654) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #4210   +/-   ##
=========================================
  Coverage     84.24%   84.24%           
  Complexity     3243     3243           
=========================================
  Files           468      468           
  Lines         10176    10176           
  Branches       1786     1786           
=========================================
  Hits           8573     8573           
  Misses          658      658           
  Partials        945      945           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd61654...d466fe6. Read the comment docs.

@3flex 3flex added this to the 1.19.0 milestone Oct 30, 2021
@3flex 3flex added the housekeeping Marker for housekeeping tasks and refactorings label Oct 30, 2021
@3flex
3flex merged commit 795ed03 into detekt:main Oct 30, 2021
@3flex
3flex deleted the ge-plugin branch October 30, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Marker for housekeeping tasks and refactorings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants