Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exclude tests in WildcardImport Rule #5121

Merged
merged 3 commits into from Jul 25, 2022
Merged

Conversation

BraisGabin
Copy link
Collaborator

Context: #5116 (comment)

This PR is also kind of "housekeeping" because I remove the 'java.util.*' as a valid Wildcard import as we have in the default values.

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #5121 (fc5b7c0) into main (c46b9ec) will increase coverage by 84.92%.
The diff coverage is n/a.

Current head fc5b7c0 differs from pull request most recent head 3feb39f. Consider uploading reports for the commit 3feb39f to get more accurate results

@@             Coverage Diff             @@
##             main    #5121       +/-   ##
===========================================
+ Coverage        0   84.92%   +84.92%     
- Complexity      0     3614     +3614     
===========================================
  Files           0      502      +502     
  Lines           0    11886    +11886     
  Branches        0     2237     +2237     
===========================================
+ Hits            0    10094    +10094     
- Misses          0      689      +689     
- Partials        0     1103     +1103     
Impacted Files Coverage Δ
...ab/arturbosch/detekt/formatting/KtLintMultiRule.kt 96.42% <ø> (ø)
...etekt/generator/printer/defaultconfig/Exclusion.kt 96.87% <ø> (ø)
...ab/arturbosch/detekt/rules/naming/PackageNaming.kt 100.00% <0.00%> (ø)
...lab/arturbosch/detekt/core/FileProcessorLocator.kt 69.23% <0.00%> (ø)
...arturbosch/detekt/core/rules/SingleRuleProvider.kt 100.00% <0.00%> (ø)
...osch/detekt/core/baseline/BaselineResultMapping.kt 78.57% <0.00%> (ø)
...b/arturbosch/detekt/rules/style/ForbiddenImport.kt 96.00% <0.00%> (ø)
...bosch/detekt/rules/complexity/LabeledExpression.kt 86.20% <0.00%> (ø)
.../arturbosch/detekt/core/reporting/ReportLocator.kt 92.30% <0.00%> (ø)
...osch/detekt/generator/printer/DeprecatedPrinter.kt 100.00% <0.00%> (ø)
... and 494 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46b9ec...3feb39f. Read the comment docs.

@3flex
Copy link
Collaborator

3flex commented Jul 25, 2022

This looks like it has #5130 mixed in, I'm guessing that was unintentional and that this should be focused only on the update to remove the exclusion for test sources and fix the new issues that are reported?

@BraisGabin
Copy link
Collaborator Author

This looks like it has #5130 mixed in, I'm guessing that was unintentional and that this should be focused only on the update to remove the exclusion for test sources and fix the new issues that are reported?

You are right. I have far too many open branches right now >_<

@3flex 3flex added the notable changes Marker for notable changes in the changelog label Jul 25, 2022
3flex
3flex approved these changes Jul 25, 2022
@3flex
Copy link
Collaborator

3flex commented Jul 25, 2022

I've tagged it as a notable change because some users will get new issues reported if they're using the default config.

@3flex 3flex merged commit bcb245e into main Jul 25, 2022
19 checks passed
@3flex 3flex deleted the improve-wildcard-rule branch July 25, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation formatting notable changes Marker for notable changes in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants