Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive of in UnnecessaryParentheses #5684

Merged
merged 2 commits into from Feb 21, 2023
Merged

Fix false positive of in UnnecessaryParentheses #5684

merged 2 commits into from Feb 21, 2023

Conversation

atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Jan 7, 2023

Fixes #5631

@github-actions github-actions bot added the rules label Jan 7, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 8, 2023
View reviewed changes
...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryParenthesesSpec.kt Fixed Show fixed Hide fixed
...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryParenthesesSpec.kt Fixed Show fixed Hide fixed
...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryParenthesesSpec.kt Fixed Show fixed Hide fixed
...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryParenthesesSpec.kt Fixed Show fixed Hide fixed
...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryParenthesesSpec.kt Fixed Show fixed Hide fixed
...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryParenthesesSpec.kt Fixed Show fixed Hide fixed
...-style/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryParenthesesSpec.kt Fixed Show fixed Hide fixed
@vercel
Copy link

vercel bot commented Jan 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
detekt 🔄 Building (Inspect) Jan 9, 2023 at 11:29AM (UTC)

@BraisGabin BraisGabin mentioned this pull request Jan 12, 2023
Closed
@github-actions
Copy link

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the Detekt release notes.

Generated by 🚫 dangerJS against df5b3f2

@atulgpt
Copy link
Contributor Author

atulgpt commented Feb 3, 2023

Hi @BraisGabin / @cortinico this PR is good for merge, right? Let me know if o/w

@BraisGabin BraisGabin merged commit 2c150b9 into detekt:main Feb 21, 2023
@atulgpt atulgpt deleted the fixes-5631 branch February 21, 2023 22:57
@atulgpt
Copy link
Contributor Author

atulgpt commented Feb 26, 2023

Hi @BraisGabin, here as well milestone is not set 🙂

@cortinico cortinico added this to the 1.23.0 milestone Feb 26, 2023
@cortinico
Copy link
Member

Hi @BraisGabin, here as well milestone is not set 🙂

Added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico left review comments

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
rules
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

UnnecessaryParentheses false positive when wrapping a unary operator and value
3 participants
@atulgpt @cortinico @BraisGabin