Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find range call using recursion #6164

Merged
merged 1 commit into from Jun 5, 2023
Merged

Conversation

atulgpt
Copy link
Contributor

@atulgpt atulgpt commented May 29, 2023

Fixes #6163

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #6164 (05b0d51) into main (f51c5a3) will decrease coverage by 0.46%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##               main    #6164      +/-   ##
============================================
- Coverage     84.94%   84.48%   -0.46%     
+ Complexity     4026     3995      -31     
============================================
  Files           569      568       -1     
  Lines         13498    13433      -65     
  Branches       2381     2372       -9     
============================================
- Hits          11466    11349     -117     
- Misses          869      934      +65     
+ Partials       1163     1150      -13     
Impacted Files Coverage Δ
...urbosch/detekt/rules/performance/ForEachOnRange.kt 85.29% <80.95%> (+11.10%) ⬆️
...h/detekt/core/baseline/IndentingXMLStreamWriter.kt 57.53% <100.00%> (+1.19%) ⬆️

... and 29 files with indirect coverage changes

@BraisGabin BraisGabin added this to the 2.0.0 milestone Jun 5, 2023
@BraisGabin BraisGabin merged commit 59e222b into detekt:main Jun 5, 2023
22 of 23 checks passed
@atulgpt atulgpt deleted the fixes/6163 branch June 5, 2023 19:46
@cortinico cortinico added the pick request Marker for PRs that should be ported to the 1.0 release branch label Jul 15, 2023
cortinico pushed a commit to cortinico/detekt that referenced this pull request Jul 15, 2023
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core pick request Marker for PRs that should be ported to the 1.0 release branch rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False negative on ForEachOnRange
4 participants