Skip to content

Add missing jdkHome and languageVersion properties to DetektCreateBaselineTask#6284

Merged
cortinico merged 3 commits into
detekt:mainfrom
Hexcles:patch-1
Jul 15, 2023
Merged

Add missing jdkHome and languageVersion properties to DetektCreateBaselineTask#6284
cortinico merged 3 commits into
detekt:mainfrom
Hexcles:patch-1

Conversation

@Hexcles

@Hexcles Hexcles commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

This is a minimal version of #6214 to fix #6167 only in a point release (1.23.1) given that 2.x will come with major changes in these tasks.

@Hexcles

Hexcles commented Jul 14, 2023

Copy link
Copy Markdown
Contributor Author

@cortinico

@detekt-ci

detekt-ci commented Jul 14, 2023

Copy link
Copy Markdown
Collaborator
Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against fe40638

@cortinico cortinico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3flex thoughts?

@cortinico cortinico added this to the 2.0.0 milestone Jul 14, 2023
@Hexcles

Hexcles commented Jul 14, 2023

Copy link
Copy Markdown
Contributor Author

Note that I set the base branch to release/1.x, not main, with the intention to release this in 1.23.1 only based on my understanding of prior discussions. Please change it if that's not correct.

@codecov

codecov Bot commented Jul 14, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6284 (fe40638) into main (ad80630) will increase coverage by 0.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #6284      +/-   ##
============================================
+ Coverage     84.94%   85.19%   +0.24%     
- Complexity     4026     4029       +3     
============================================
  Files           569      568       -1     
  Lines         13498    13421      -77     
  Branches       2381     2376       -5     
============================================
- Hits          11466    11434      -32     
+ Misses          869      829      -40     
+ Partials       1163     1158       -5     

see 61 files with indirect coverage changes

@cortinico
cortinico changed the base branch from release/1.x to main July 15, 2023 12:38
@cortinico

Copy link
Copy Markdown
Member

Note that I set the base branch to release/1.x, not main, with the intention to release this in 1.23.1 only based on my understanding of prior discussions. Please change it if that's not correct.

Let's merge this to main and I'll pick it on the release branch

@Hexcles Hexcles changed the title Add missing jdkHome and languageVersionProp properties to DetektCreateBaselineTask Add missing jdkHome and languageVersion properties to DetektCreateBaselineTask Jul 15, 2023
@cortinico cortinico added the pick request Marker for PRs that should be ported to the 1.0 release branch label Jul 15, 2023
@cortinico
cortinico merged commit 6e36a9b into detekt:main Jul 15, 2023
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gradle-plugin pick request Marker for PRs that should be ported to the 1.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jdkHome is not passed to CLI from DetektCreateBaselineTask

4 participants