-
-
Notifications
You must be signed in to change notification settings - Fork 794
Add missing jdkHome and languageVersion properties to DetektCreateBaselineTask #6284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3flex thoughts?
Note that I set the base branch to |
Codecov Report
@@ Coverage Diff @@
## main #6284 +/- ##
============================================
+ Coverage 84.94% 85.19% +0.24%
- Complexity 4026 4029 +3
============================================
Files 569 568 -1
Lines 13498 13421 -77
Branches 2381 2376 -5
============================================
- Hits 11466 11434 -32
+ Misses 869 829 -40
+ Partials 1163 1158 -5 |
detekt-gradle-plugin/src/main/kotlin/io/gitlab/arturbosch/detekt/DetektCreateBaselineTask.kt
Outdated
Show resolved
Hide resolved
Let's merge this to |
This is a minimal version of #6214 to fix #6167 only in a point release (1.23.1) given that 2.x will come with major changes in these tasks.