Add missing jdkHome and languageVersion properties to DetektCreateBaselineTask#6284
Merged
Conversation
Contributor
Author
Collaborator
cortinico
approved these changes
Jul 14, 2023
Contributor
Author
|
Note that I set the base branch to |
Codecov Report
@@ Coverage Diff @@
## main #6284 +/- ##
============================================
+ Coverage 84.94% 85.19% +0.24%
- Complexity 4026 4029 +3
============================================
Files 569 568 -1
Lines 13498 13421 -77
Branches 2381 2376 -5
============================================
- Hits 11466 11434 -32
+ Misses 869 829 -40
+ Partials 1163 1158 -5 |
3flex
approved these changes
Jul 14, 2023
Member
Let's merge this to |
cortinico
pushed a commit
that referenced
this pull request
Jul 15, 2023
mgroth0
pushed a commit
to mgroth0/detekt
that referenced
this pull request
Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal version of #6214 to fix #6167 only in a point release (1.23.1) given that 2.x will come with major changes in these tasks.