Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consumeGeneratedConfig #6374

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Improve consumeGeneratedConfig #6374

merged 2 commits into from
Aug 7, 2023

Conversation

BraisGabin
Copy link
Member

While I was working on #5853 I did these minor boy scouts.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Aug 6, 2023
@detekt-ci detekt-ci added the build label Aug 6, 2023
@detekt-ci
Copy link
Collaborator

detekt-ci commented Aug 6, 2023

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against dedac0f

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #6374 (dedac0f) into main (cb77385) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #6374   +/-   ##
=========================================
  Coverage     85.18%   85.18%           
  Complexity     4006     4006           
=========================================
  Files           570      570           
  Lines         13395    13395           
  Branches       2358     2358           
=========================================
  Hits          11410    11410           
  Misses          834      834           
  Partials       1151     1151           

Copy link
Member

@3flex 3flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd made identical changes in my branch :)

@3flex 3flex merged commit e629653 into main Aug 7, 2023
23 checks passed
@3flex 3flex deleted the Improve-ConsumeGeneratedConfig branch August 7, 2023 01:09
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
* Use TaskProvider instead of task name

* Remove redundant apply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants