Skip to content

UnconditionalJumpStatementInLoop: don't report a conditional break in a single body expression - #6443

Merged
BraisGabin merged 2 commits into
detekt:mainfrom
t-kameyama:issue_6442
Aug 31, 2023
Merged

BraisGabin merged 2 commits into
detekt:mainfrom
t-kameyama:issue_6442

Conversation

@t-kameyama

Copy link
Copy Markdown
Contributor

Fixes #6442

@BraisGabin
BraisGabin enabled auto-merge (squash) August 31, 2023 07:38
@codecov

codecov Bot commented Aug 31, 2023 •

Copy link
Copy Markdown

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (5672df8) 85.21% compared to head (729abfe) 85.21%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6443   +/-   ##
=========================================
  Coverage     85.21%   85.21%           
+ Complexity     4031     4028    -3     
=========================================
  Files           566      566           
  Lines         13175    13178    +3     
  Branches       2365     2366    +1     
=========================================
+ Hits          11227    11230    +3     
  Misses          774      774           
  Partials       1174     1174           
Files Changed Coverage Δ
...ekt/rules/bugs/UnconditionalJumpStatementInLoop.kt 95.83% <75.00%> (+0.59%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@detekt-ci

Copy link
Copy Markdown
Collaborator
Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against 729abfe

@simaotwx

Copy link
Copy Markdown

Thanks!

@BraisGabin BraisGabin added this to the 2.0.0 milestone Aug 31, 2023
@t-kameyama
t-kameyama deleted the issue_6442 branch August 31, 2023 08:06
@cortinico cortinico added the pick request Marker for PRs that should be ported to the 1.0 release branch label Sep 1, 2023
cortinico pushed a commit that referenced this pull request Oct 30, 2023
… a single body expression (#6443)

Co-authored-by: Brais Gabín <braisgabin@gmail.com>
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
… a single body expression (detekt#6443)

Co-authored-by: Brais Gabín <braisgabin@gmail.com>

This branch was successfully deployed

1 active deployment
Preview — 729abfe0 Deployed Aug 31, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pick request Marker for PRs that should be ported to the 1.0 release branch rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specific code causes false positive of UnconditionalJumpStatementInLoop

5 participants