-
-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove check for deprectated functions toUpperCase and toLowerCase #6548
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6548 +/- ##
=========================================
Coverage 85.10% 85.11%
+ Complexity 4083 4079 -4
=========================================
Files 570 570
Lines 13376 13363 -13
Branches 2406 2401 -5
=========================================
- Hits 11384 11374 -10
Misses 792 792
+ Partials 1200 1197 -3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo a minor nit
@@ -33,17 +30,13 @@ import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe | |||
* "Timestamp: %d".format(System.currentTimeMillis()) | |||
* | |||
* val str: String = getString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this line also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@@ -33,17 +30,13 @@ import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe | |||
* "Timestamp: %d".format(System.currentTimeMillis()) | |||
* | |||
* val str: String = getString() | |||
* str.toUpperCase() | |||
* str.toLowerCase() | |||
* </noncompliant> | |||
* | |||
* <compliant> | |||
* String.format(Locale.US, "Timestamp: %d", System.currentTimeMillis()) | |||
* "Timestamp: %d".format(Locale.US, System.currentTimeMillis()) | |||
* | |||
* val str: String = getString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this line also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
toUpperCase and toLowerCase are deprecated, the ImplicitDefaultLocale should not check usage for them anymore Closes detekt#6343
…etekt#6548) toUpperCase and toLowerCase are deprecated, the ImplicitDefaultLocale should not check usage for them anymore Closes detekt#6343
toUpperCase
andtoLowerCase
are deprecated, theImplicitDefaultLocale
should not check usage for them anymoreCloses #6343