Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodSignature - Add the condition of receiver should be null #6570

Merged

Conversation

atulgpt
Copy link
Contributor

@atulgpt atulgpt commented Oct 29, 2023

Fixes #6569

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf0e3f6) 85.18% compared to head (6a350d4) 85.18%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6570   +/-   ##
=========================================
  Coverage     85.18%   85.18%           
  Complexity     4061     4061           
=========================================
  Files           565      565           
  Lines         13321    13327    +6     
  Branches       2401     2407    +6     
=========================================
+ Hits          11347    11353    +6     
  Misses          773      773           
  Partials       1201     1201           
Files Coverage Δ
.../gitlab/arturbosch/detekt/rules/MethodSignature.kt 70.83% <100.00%> (+9.72%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schalkms schalkms added this to the 1.23.2 milestone Oct 30, 2023
@cortinico cortinico modified the milestones: 1.23.2, 2.0.0 Oct 30, 2023
@BraisGabin BraisGabin added the pick request Marker for PRs that should be ported to the 1.0 release branch label Nov 2, 2023
@BraisGabin BraisGabin merged commit 3f55a9b into detekt:main Nov 2, 2023
23 checks passed
@atulgpt atulgpt deleted the fixes/6569/fix-equality-method-check branch November 2, 2023 15:29
@cortinico cortinico changed the title Add the condition of receiver should be null MethodSignature - Add the condition of receiver should be null Nov 23, 2023
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pick request Marker for PRs that should be ported to the 1.0 release branch rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on EqualsWithHashCodeExist
5 participants