Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set detekt report default names based on task name when using KMP #6957

Merged
merged 1 commit into from Feb 9, 2024

Conversation

3flex
Copy link
Member

@3flex 3flex commented Feb 9, 2024

This ensures uniqueness within a project and prevents tasks overwriting reports generated by other detekt tasks in the same project.

Fixes #4035

This ensures uniqueness within a project and prevents tasks overwriting
reports generated by other detekt tasks in the same project.
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against e3c1e4b

@3flex 3flex added this to the 2.0.0 milestone Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e962ab6) 83.79% compared to head (e3c1e4b) 83.79%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6957   +/-   ##
=========================================
  Coverage     83.79%   83.79%           
  Complexity     3932     3932           
=========================================
  Files           579      579           
  Lines         12100    12100           
  Branches       2506     2506           
=========================================
  Hits          10139    10139           
  Misses          710      710           
  Partials       1251     1251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3flex 3flex merged commit bc83921 into detekt:main Feb 9, 2024
21 checks passed
@3flex 3flex deleted the 4035-fix branch February 11, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

one report for all platforms (xml) in MPP but each platform overrides it
3 participants