Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests on SuppressionSpec.kt #7109

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Add missing tests on SuppressionSpec.kt #7109

merged 1 commit into from
Apr 7, 2024

Conversation

BraisGabin
Copy link
Member

This PR is related with #7107 and #7108. While working on #7107 I found an edge case that we didn't have covered and I covered it. And then on #7108 I rewrote all the tests.

So instead of adding the tests of that edge case on #7107 I'm waiting for those two PRs to be merged and then add the tests that you see here.

@BraisGabin BraisGabin added the housekeeping Marker for housekeeping tasks and refactorings label Mar 28, 2024
@detekt-ci detekt-ci added the core label Mar 28, 2024
@BraisGabin BraisGabin force-pushed the supressions-tests branch 2 times, most recently from cfb3651 to d1dae47 Compare March 28, 2024 01:04
Base automatically changed from supressions-tests to main April 6, 2024 21:37
@BraisGabin BraisGabin marked this pull request as ready for review April 6, 2024 21:41
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (04bc262) to head (bd1bda3).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7109   +/-   ##
=========================================
  Coverage     83.85%   83.85%           
  Complexity     3949     3949           
=========================================
  Files           578      578           
  Lines         12155    12155           
  Branches       2493     2493           
=========================================
  Hits          10193    10193           
  Misses          733      733           
  Partials       1229     1229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3flex 3flex merged commit 301f8bd into main Apr 7, 2024
21 checks passed
@3flex 3flex deleted the supressions-tests-2 branch April 7, 2024 00:49
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against bd1bda3

@cortinico cortinico added this to the 2.0.0 milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants