Stricter paths #7147
Merged
Stricter paths #7147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
commented
Apr 8, 2024
Comment on lines
+56
to
+58
| require(absolutePath.isAbsolute) { "absolutePath should be absolute" } | ||
| require(basePath?.isAbsolute != false) { "basePath should be absolute" } | ||
| require(relativePath?.isAbsolute != true) { "relativePath should not be absolute" } |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7147 +/- ##
============================================
- Coverage 84.70% 84.67% -0.03%
Complexity 3983 3983
============================================
Files 578 578
Lines 12151 12153 +2
Branches 2495 2498 +3
============================================
- Hits 10292 10291 -1
Misses 625 625
- Partials 1234 1237 +3 ☔ View full report in Codecov by Sentry. |
BraisGabin
force-pushed
the
stricter-paths
branch
from
2314f98
to
983b626
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
983b626
to
62d1b03
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
62d1b03
to
a04f6a0
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
a04f6a0
to
3bc7ef7
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
3bc7ef7
to
1bba878
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
1bba878
to
464dc78
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
464dc78
to
4ff6014
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
4ff6014
to
88b5759
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
88b5759
to
1e652e7
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
1e652e7
to
bcdb678
Compare
|
Still working on make Windows tests happy :'(. My main problem right now is that The main problem is that I don't have windows so I need to use CI to debug the problems :'( |
BraisGabin
force-pushed
the
stricter-paths
branch
from
3da2dcc
to
e39ba24
Compare
...-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/IssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
...-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/IssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
...-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/IssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
...-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/IssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
...-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/IssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
...-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/IssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
...-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/IssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
...-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/IssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
...-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/reporting/console/IssuesReportSpec.kt
Fixed
Show fixed
Hide fixed
BraisGabin
force-pushed
the
stricter-paths
branch
from
e39ba24
to
1b67b62
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
1b67b62
to
f04afbb
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
f04afbb
to
061410c
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
061410c
to
89762f2
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
89762f2
to
e9f2b9c
Compare
BraisGabin
force-pushed
the
stricter-paths
branch
from
e9f2b9c
to
a73350f
Compare
cortinico
approved these changes
Apr 20, 2024
|
|
||
| assertThat(filePath.toString()) | ||
| .isEqualTo("FilePath(absolutePath=${ps}a${ps}b${ps}c, basePath=null, relativePath=null)") |
BraisGabin
force-pushed
the
stricter-paths
branch
from
a73350f
to
23381a1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7140
This PR makes our core more strict to how the paths should look like. I know that
KtFileswill be removed. but that's the reason I'm doing this now. Our tests were a bit "loose" on the paths. With this change our tests are a better representation of what happen in the real life and can spot real bugs once we start to refactor this part of the code to removeKtFiles.