Rewrite MaxLineLength & TrailingWhitespace to avoid problematic offset calcs #7270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative values are invalid as the text range must start and end within the range 0 to file.text.length
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7270 +/- ##
=======================================
Coverage ? 84.74%
Complexity ? 3990
=======================================
Files ? 578
Lines ? 12027
Branches ? 2483
=======================================
Hits ? 10192
Misses ? 606
Partials ? 1229 ☔ View full report in Codecov by Sentry. |
BraisGabin
approved these changes
May 8, 2024
detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/MaxLineLength.kt
Outdated
Show resolved
Hide resolved
BraisGabin
reviewed
May 8, 2024
detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/Junk.kt
Show resolved
Hide resolved
3flex
changed the title
BraisGabin
approved these changes
May 8, 2024
There was a problem hiding this comment.
LGTM
This PR is really related with #7259. Because these two rules are the more problematic ones related with the null KtElement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.