Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename UnusedPrivateMember to UnusedPrivateFunction #7324

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

BraisGabin
Copy link
Member

We were calling UnusedPrivateMember to a rule that only checked functions. So I renamed it to make more clear what it does. Also, it was called like this because time ago this rule handled lots of cases so for that reason I also reduced the number of aliases.

@BraisGabin BraisGabin changed the title Rename UnusedPrivateMember to UnusedPrivateFunction Rename UnusedPrivateMember to UnusedPrivateFunction May 20, 2024
@BraisGabin BraisGabin added the notable changes Marker for notable changes in the changelog label May 20, 2024
@BraisGabin BraisGabin added this to the 2.0.0 milestone May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (ac0ee12) to head (05e2d4d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7324   +/-   ##
=========================================
  Coverage     84.31%   84.31%           
  Complexity     4149     4149           
=========================================
  Files           573      573           
  Lines         11888    11888           
  Branches       2458     2458           
=========================================
  Hits          10023    10023           
  Misses          613      613           
  Partials       1252     1252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@detekt-ci
Copy link
Collaborator

detekt-ci commented May 20, 2024

Warnings
⚠️

It looks like you're editing the un-versioned copy of our website. This affects only users on the 'next' version of detekt, and it's correct only if you intend to document a future change or feature. If you intended to make a change also for the current version of detekt, please make sure you edit the equivalent file inside website/versioned_docs/ as well.

Messages
📖

Thank you very much for making our website better ❤️!

Generated by 🚫 dangerJS against 05e2d4d

Comment on lines -276 to -278
UnusedPrivateMember:
active: true
allowedNames: '(_|ignored|expected)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to this one?

Copy link
Member Author

@BraisGabin BraisGabin May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to enable this rule on our own configuration, it is enabled by default. And we don't need any special value for allowedNames on detekt either.

@BraisGabin BraisGabin merged commit da6a143 into main Jun 5, 2024
21 checks passed
@BraisGabin BraisGabin deleted the UnusedPrivateFunction branch June 5, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli documentation notable changes Marker for notable changes in the changelog rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants