-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename UnusedPrivateMember
to UnusedPrivateFunction
#7324
Conversation
UnusedPrivateMember
to UnusedPrivateFunction
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7324 +/- ##
=========================================
Coverage 84.31% 84.31%
Complexity 4149 4149
=========================================
Files 573 573
Lines 11888 11888
Branches 2458 2458
=========================================
Hits 10023 10023
Misses 613 613
Partials 1252 1252 ☔ View full report in Codecov by Sentry. |
9a6c45b
to
46225f6
Compare
46225f6
to
318eae2
Compare
|
318eae2
to
2a49889
Compare
UnusedPrivateMember: | ||
active: true | ||
allowedNames: '(_|ignored|expected)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to enable this rule on our own configuration, it is enabled by default. And we don't need any special value for allowedNames
on detekt either.
2a49889
to
2148a47
Compare
2148a47
to
05e2d4d
Compare
We were calling
UnusedPrivateMember
to a rule that only checked functions. So I renamed it to make more clear what it does. Also, it was called like this because time ago this rule handled lots of cases so for that reason I also reduced the number ofaliases
.