#7360: Add 'assign' to operatorSet of UnusedImport

[PhilippNowak96]

This PR adds assign to the operatorSet of the UnusedImport rule so that kotlin-dsl assignments are not reporting unused imports.

Resolves #7360

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (da020ea) to head (17516a6).

❗ Current head 17516a6 differs from pull request most recent head 609a198

Please upload reports for the commit 609a198 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #7361   +/-   ##
=========================================
  Coverage     84.50%   84.50%           
  Complexity     4168     4168           
=========================================
  Files           573      573           
  Lines         11897    11900    +3     
  Branches       2461     2462    +1     
=========================================
+ Hits          10053    10056    +3     
  Misses          591      591           
  Partials       1253     1253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BraisGabin]

🤔 sorry, but I can't find assign as an operator on the kotlin documentation: https://kotlinlang.org/docs/operator-overloading.html where is it documented? Or is this gradle specific?

[PhilippNowak96]

@BraisGabin this seems to be some gradle specific stuff. I read this article about it https://blog.gradle.org/simpler-kotlin-dsl-property-assignment and then verified it by the test

[3flex]

Yes it's Gradle specific and implemented as a compiler plugin applied by Gradle when it compiles scripts.

Kotlin offers the extension point to customise behaviour of the assign operator (and possibly others though I'm not sure).

Given this is Gradle specific, and in line with our general philosophy of not building library or tool-specific config as defaults, I think it would be better to introduce a config option for additionalOperators where things like this can be added for those that need it.

[PhilippNowak96]

Thanks @3flex for the clarification ☺️ I like the idea introducing a separate set for non language default operators. Changes have been pushed.

[3flex]

Sorry I didn't check this more closely - in my earlier comment I meant that the assign operator should be configurable and something to set in the YAML config. It's been implemented here as a hardcoded value in the rule but it's highly specific to Gradle so should be something that can be configured by users who are using that for Gradle analysis and not part of the standard rule config which should be framework-, tool- and library-agnostic.

I'll open a new issue.