Remove extensions.disableDefaultRuleSets in favor of RulesSpec.RunPolicy.DisableDefaultRuleSets
#7380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraisGabin
added
the
breaking change
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/rules/RuleSets.kt
Fixed
Show fixed
Hide fixed
detekt-tooling/src/main/kotlin/io/github/detekt/tooling/api/spec/RulesSpec.kt
Fixed
Show fixed
Hide fixed
detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/rules/RuleSets.kt
Fixed
Show fixed
Hide fixed
detekt-core/src/main/kotlin/io/gitlab/arturbosch/detekt/core/rules/RuleSets.kt
Fixed
Show fixed
Hide fixed
detekt-tooling/src/main/kotlin/io/github/detekt/tooling/api/spec/RulesSpec.kt
Fixed
Show fixed
Hide fixed
detekt-tooling/src/main/kotlin/io/github/detekt/tooling/api/spec/RulesSpec.kt
Fixed
Show fixed
Hide fixed
BraisGabin
force-pushed
the
refactor-rulesets-2
branch
from
a984684
to
1dcfd54
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7380 +/- ##
============================================
- Coverage 84.50% 84.49% -0.02%
+ Complexity 4160 4159 -1
============================================
Files 572 572
Lines 11890 11886 -4
Branches 2461 2461
============================================
- Hits 10048 10043 -5
Misses 590 590
- Partials 1252 1253 +1 ☔ View full report in Codecov by Sentry. |
BraisGabin
force-pushed
the
refactor-rulesets-2
branch
from
1dcfd54
to
a39e433
Compare
BraisGabin
force-pushed
the
refactor-rulesets-2
branch
from
a39e433
to
26c5cf9
Compare
BraisGabin
force-pushed
the
refactor-rulesets-2
branch
from
26c5cf9
to
9d5ce85
Compare
cortinico
approved these changes
Jun 22, 2024
detekt-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/rules/RuleSetsSpec.kt
Outdated
Show resolved
Hide resolved
BraisGabin
force-pushed
the
refactor-rulesets-2
branch
from
9d5ce85
to
1119d07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
RulesSpec.RunPolicy.DisableDefaultRuleSetsand remove the booleanextensions.disableDefaultRuleSets. This makes our public api a bit easier and the code that implements it too.