Detekt 1.18.1 #144
Detekt 1.18.1 #144
Conversation
.github/workflows/pre-merge.yaml
Outdated
| @@ -13,7 +13,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest, windows-latest] | |||
| jdk: [8, 11] | |||
| jdk: [8, 11, 15, 16] | |||
There was a problem hiding this comment.
| jdk: [8, 11, 15, 16] | |
| jdk: [8, 11, 16] |
We generally support only LTS and the latest released version
There was a problem hiding this comment.
I've updated this as well
pom.xml
Outdated
| @@ -38,6 +38,11 @@ | |||
| <name>jcenter</name> | |||
| <url>https://jcenter.bintray.com</url> | |||
There was a problem hiding this comment.
Please remove this repository as well as you're adding MavenCentral
There was a problem hiding this comment.
Hmm, I'm not sure why I even added that one, it should work without it as well, I've committed a change to this.
There was a problem hiding this comment.
I'm unsure it will work without any repository defined
There was a problem hiding this comment.
It seems like it does actually 👀
There was a problem hiding this comment.
Yeah, it should work fine if all you need is Maven Central, the Maven Super pom defines that.
pom.xml
Outdated
| <url>https://jcenter.bintray.com</url> | ||
| </repository> | ||
| </repositories> | ||
|
|
||
| <pluginRepositories> |
There was a problem hiding this comment.
I think this part could be removed as well, but it might belong in its own PR?
There was a problem hiding this comment.
Yes can you change also this to Maven Central? Now it's working as JCenter is still mirroring Central but it will break in the future.
Since you already tackled this problem for the build dependencies, makes sense to do it as well for the plugin repos.
There was a problem hiding this comment.
I'll remove that as well then.
|
Kudos, SonarCloud Quality Gate passed!
|
Updated to Detekt 1.18.1, plus new versions of other dependencies