Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for title bar (i3) #30

Closed
jfaltis opened this issue Aug 23, 2022 · 6 comments
Closed

Add support for title bar (i3) #30

jfaltis opened this issue Aug 23, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@jfaltis
Copy link

jfaltis commented Aug 23, 2022

I am currently using i3 and the border ignores the title bar. It would be cool if it also included the title bar.

for_window [class=".*"] title_format " %title" could be used to add a padding to the title bar text in i3 to not be obstructed by the rounded corners.

I don't know how easy this is to fix but a workaround would be allowing to set the radius of the corners individually. This allows settings the top left and top right corner to radius=0 which would at least result in rounded corners at the bottom.

Great work!

2022-08-23_17-41

@deter0 deter0 added the enhancement New feature or request label Aug 23, 2022
@deter0
Copy link
Owner

deter0 commented Aug 23, 2022

Adding support for the i3 title-bar seems a bit specific to i3 and people with title-bars. I think I'm gonna add an offset configuration where you can increase the offset, would that resolve this?

@coloursofnoise
Copy link

That would likely solve it for people who have all titlebars enabled, but if you disable titlebars i3 will still add them on tabbed and stacked layouts only if there's more than one window.

@deter0
Copy link
Owner

deter0 commented Aug 24, 2022

@coloursofnoise Yeah that is annoying. I have implemented the offsets it should be available in 3.1. Do you have any suggestions on how we could fix it?

@jfaltis
Copy link
Author

jfaltis commented Aug 24, 2022

Adding support for the i3 title-bar seems a bit specific to i3 and people with title-bars. I think I'm gonna add an offset configuration where you can increase the offset, would that resolve this?

I agree with you. This seems like an appropriate way to fix this.

@coloursofnoise
Copy link

Do you have any suggestions on how we could fix it?

As far as I'm aware the only viable option would be to check whether the current layout is stacked/tabbed and there's more than one window in it, but that's definitely too specific to i3 in my opinion

@deter0
Copy link
Owner

deter0 commented Aug 26, 2022

Okay, since the offset has been implemented I'm closing this as OP said that would fix it

@deter0 deter0 closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants