-
Notifications
You must be signed in to change notification settings - Fork 347
/
logpattern.go
223 lines (188 loc) · 6.48 KB
/
logpattern.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
package logpattern
import (
"context"
"fmt"
"regexp"
lru "github.com/hashicorp/golang-lru/v2"
"github.com/determined-ai/determined/master/internal/db"
"github.com/determined-ai/determined/master/internal/task/tasklogger"
"github.com/determined-ai/determined/master/pkg/model"
"github.com/determined-ai/determined/master/pkg/schemas/expconf"
"github.com/uptrace/bun"
)
const regexCacheSize = 256
var defaultSingleton *LogPatternPolicies
// LogPatternPolicies performs log pattern checks.
type LogPatternPolicies struct {
regexCache *lru.Cache[string, *regexp.Regexp]
}
// New create the log pattern policies singleton.
func New(ctx context.Context) (*LogPatternPolicies, error) {
regexCache, err := lru.New[string, *regexp.Regexp](regexCacheSize)
if err != nil {
return nil, fmt.Errorf("creating LRU cache: %w", err)
}
return &LogPatternPolicies{
regexCache: regexCache,
}, nil
}
func (l *LogPatternPolicies) getCompiledRegex(regex string) (*regexp.Regexp, error) {
if compiledRegex, ok := l.regexCache.Get(regex); ok {
return compiledRegex, nil
}
compiledRegex, err := regexp.Compile(regex)
if err != nil {
return nil, fmt.Errorf("compiling regex '%s': %w", regex, err)
}
l.regexCache.Add(regex, compiledRegex)
return compiledRegex, nil
}
func (l *LogPatternPolicies) monitor(ctx context.Context,
taskID model.TaskID, logs []*model.TaskLog, policies expconf.LogPoliciesConfig,
) error {
// TODO when we add rm specific log grabbing we will need to also monitor them.
for _, policy := range policies {
compiledRegex, err := l.getCompiledRegex(policy.Pattern())
if err != nil {
return err
}
for _, log := range logs {
if log.AgentID == nil {
return fmt.Errorf("agentID must be non nil to monitor logs")
}
if compiledRegex.MatchString(log.Log) {
switch policy.Action().GetUnionMember().(type) {
case expconf.LogActionCancelRetries:
if err := addDontRetry(
ctx, model.TaskID(log.TaskID), *log.AgentID, policy.Pattern(), log.Log,
); err != nil {
return fmt.Errorf("adding don't retry: %w", err)
}
case expconf.LogActionExcludeNode:
if err := addRetryOnDifferentNode(
ctx, model.TaskID(log.TaskID), *log.AgentID, policy.Pattern(), log.Log,
); err != nil {
return fmt.Errorf("adding retry on different node: %w", err)
}
default:
return fmt.Errorf("unrecognized log pattern policy type")
}
}
}
}
return nil
}
type retryOnDifferentNode struct {
bun.BaseModel `bun:"table:log_policy_retry_on_different_node"`
ID int `bun:"id,pk,autoincrement"`
TaskID model.TaskID `bun:"task_id"`
NodeName string `bun:"node_name"`
Regex string `bun:"regex"`
TriggeringLog string `bun:"triggering_log"`
}
// GetBlockedNodes returns nodes you can't schedule on due to log pattern policies.
func GetBlockedNodes(ctx context.Context, taskID model.TaskID) ([]string, error) {
var resp []retryOnDifferentNode
if err := db.Bun().NewSelect().Model(&resp).
Where("task_id = ?", taskID).
Column("node_name").
Distinct().
Scan(ctx, &resp); err != nil {
return nil, fmt.Errorf("getting nodes for taskID %s: %w", taskID, err)
}
var o []string
for _, r := range resp {
o = append(o, r.NodeName)
}
return o, nil
}
func addRetryOnDifferentNode(
ctx context.Context, taskID model.TaskID, nodeName, regex, triggeringLog string,
) error {
m := &retryOnDifferentNode{
TaskID: taskID,
NodeName: nodeName,
Regex: regex,
TriggeringLog: triggeringLog,
}
res, err := db.Bun().NewInsert().Model(m).
On("CONFLICT (task_id, node_name, regex) DO NOTHING"). // Only care about the first log.
Exec(ctx)
if err != nil {
return fmt.Errorf("inserting log policy retry on different node alert %+v: %w", m, err)
}
if num, err := res.RowsAffected(); err != nil {
return fmt.Errorf("retry different node rows affected: %w", err)
} else if num == 0 {
return nil
}
tasklogger.Insert(tasklogger.CreateLogFromMaster(taskID, model.LogLevelError,
fmt.Sprintf("(log '%q' matched regex %s) therefore will not schedule on %s\n",
triggeringLog, regex, nodeName)))
return nil
}
// DontRetryTrigger has information about don't retry policies that have been triggered.
type DontRetryTrigger struct {
Regex string
TriggeringLog string
}
type dontRetry struct {
bun.BaseModel `bun:"table:log_policy_dont_retry"`
ID int `bun:"id,pk,autoincrement"`
TaskID model.TaskID `bun:"task_id"`
Regex string `bun:"regex"`
NodeName string `bun:"node_name"`
TriggeringLog string `bun:"triggering_log"`
}
func addDontRetry(
ctx context.Context, taskID model.TaskID, nodeName, regex, triggeringLog string,
) error {
m := &dontRetry{
TaskID: taskID,
NodeName: nodeName,
Regex: regex,
TriggeringLog: triggeringLog,
}
if _, err := db.Bun().NewInsert().Model(m).
On("CONFLICT (task_id, regex) DO NOTHING"). // Only care about the first log.
Exec(ctx); err != nil {
return fmt.Errorf("adding don't retry policy %+v: %w", m, err)
}
// We don't send a log to the trial. The trial will do it if it failed.
return nil
}
// ShouldRetry returns a list of any triggered log policies that prevent retrying a trial.
// Returns an empty list if taskID doesn't exist. Order is not guaranteed.
// Only returns first log that triggered each regex. Multiple policies with the same regex
// will only have one DontRetryTrigger.
func ShouldRetry(ctx context.Context, taskID model.TaskID) ([]DontRetryTrigger, error) {
var models []*dontRetry
if err := db.Bun().NewSelect().Model(&models).
Where("task_id = ?", taskID).
Scan(ctx, &models); err != nil {
return nil, fmt.Errorf("getting taskID %s should retry: %w", taskID, err)
}
var out []DontRetryTrigger
for _, m := range models {
out = append(out, DontRetryTrigger{
Regex: m.Regex,
TriggeringLog: m.TriggeringLog,
})
}
return out, nil
}
// TaskLogsFromDontRetryTriggers returns informational task logs from dont retry triggers.
func TaskLogsFromDontRetryTriggers(taskID model.TaskID, t []DontRetryTrigger) []*model.TaskLog {
var regexLogs []string
for _, r := range t {
regexLogs = append(regexLogs,
fmt.Sprintf("(log %q matched regex %q)", r.TriggeringLog, r.Regex))
}
var taskLogs []*model.TaskLog
for _, l := range append([]string{
"trial failed and matched logs to a don't retry policy",
}, regexLogs...) {
taskLogs = append(taskLogs, tasklogger.CreateLogFromMaster(taskID, model.LogLevelError, l))
}
return taskLogs
}