Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing key #5650

Merged
merged 1 commit into from Jan 3, 2023
Merged

fix: add missing key #5650

merged 1 commit into from Jan 3, 2023

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Dec 28, 2022 •
edited

Description

key was missing

image

Test Plan

  • Check if there's no warnings in browser console in webhook page

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Dec 28, 2022
@netlify
Copy link

netlify bot commented Dec 28, 2022 •
edited

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit ffe9b98
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/63acce85b69cc200085d9827
😎 Deploy Preview https://deploy-preview-5650--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mapmeld
mapmeld approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@mapmeld mapmeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this

@keita-determined keita-determined merged commit c6ba866 into determined-ai:master Jan 3, 2023
@keita-determined keita-determined deleted the fix/missing-key branch January 3, 2023 17:41
@dannysauer dannysauer added this to the 0.19.10 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapmeld mapmeld mapmeld approved these changes

Assignees

@mapmeld mapmeld

Labels
cla-signed
Projects
None yet
Milestone
0.19.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keita-determined @mapmeld @dannysauer