Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo in rbac docs #5652

Merged
merged 3 commits into from Jan 3, 2023
Merged

docs: fix typo in rbac docs #5652

merged 3 commits into from Jan 3, 2023

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented Dec 29, 2022

Description

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@hamidzr hamidzr requested a review from a team as a code owner December 29, 2022 22:50
@cla-bot cla-bot bot added the cla-signed label Dec 29, 2022
@netlify
Copy link

netlify bot commented Dec 29, 2022 •
edited

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit a70a032
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/63ae1a02379049000833155e

hamidzr
hamidzr commented Dec 29, 2022
View reviewed changes
docs/cluster-setup-guide/security/rbac.rst
@@ -408,7 +408,7 @@ projects and experiments within its scope.
``WorkspaceAdmin`` role supersedes the ``Editor`` role, and includes permissions to edit or delete
workspaces, and modify role assignments within its scope.

Users who posess this role on a particular workspace can assign roles to other users on this
Users who take this role on a particular workspace can assign roles to other users on this
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take on?

@hamidzr hamidzr changed the title docs: fix a typo in rbac docs docs: fix typo in rbac docs Dec 29, 2022
@keita-determined
Copy link
Contributor

@hamidzr
i think you need to assign someone instead of @determined-ai/docs cuz there's no one in there

keita-determined
keita-determined approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Prob take on? whichever you want

@hamidzr
Copy link
Contributor Author

hamidzr commented Jan 3, 2023 •
edited

LGTM. Prob take on? whichever you want

thanks for the review. If what I have is correct let's just go with that. I'm updating some of this soon in another rbac project.

@hamidzr hamidzr self-assigned this Jan 3, 2023
@hamidzr hamidzr merged commit c71ce26 into determined-ai:master Jan 3, 2023
@hamidzr hamidzr deleted the docs-rbac-typo branch January 3, 2023 20:15
@dannysauer dannysauer added this to the 0.19.10 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keita-determined keita-determined keita-determined approved these changes

Assignees

@hamidzr hamidzr

Labels
cla-signed
Projects
None yet
Milestone
0.19.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hamidzr @keita-determined @dannysauer