[legacy] correctly pass boolean arguments in methods #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 167
💛 - Coveralls |
krzkaczor
reviewed
Dec 17, 2018
scripts/test.sh
Outdated
| @@ -1,5 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
| set -e | |||
| set -x | |||
| cd "$(dirname "$0")" | |||
There was a problem hiding this comment.
are changes in this file really vital for this PR?
There was a problem hiding this comment.
not at all, I just found the test script output a bit unreadable -- I had some errors, but didn't know from which command or test file they originated
There was a problem hiding this comment.
Can we just revert those? I use -x only for debugging purposes, I don't leave that in prod code (and this is how all other scripts are written).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120