Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethers: add const assertion for exported ABI #783

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

kdembler
Copy link
Contributor

Fixes #782

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2022

🦋 Changeset detected

Latest commit: dc362fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@typechain/ethers-v5 Minor
@typechain/hardhat Patch
test-e2e Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ziad-saab
Copy link

@krzkaczor what would it take to get this merged?

@kdembler
Copy link
Contributor Author

@krzkaczor Could you please take a look? Without this change, projects depending on Typechain bindings will not be able to use wagmi 0.7+ in a type-safe way.

@dennzimm
Copy link

+1

@royalaid
Copy link

I would also like to echo support for this, it seems to be the easiest way to achieve a nice bridge between wagmi and typechain.

@krzkaczor krzkaczor merged commit 31e6957 into dethcrypto:master Dec 12, 2022
@krzkaczor
Copy link
Member

Thanks for this @kdembler. It's released as part of:
https://github.com/dethcrypto/TypeChain/releases/tag/%40typechain%2Fhardhat%406.1.5

Sorry that it took a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ethers] Mark exported ABI as const for better type analysis
5 participants