Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow Proxies #41

Merged
merged 9 commits into from
Nov 12, 2021
Merged

Follow Proxies #41

merged 9 commits into from
Nov 12, 2021

Conversation

hasparus
Copy link
Contributor

@hasparus hasparus commented Nov 9, 2021

What's changed?

We now detect proxies when fetching ABI and fetch implementation ABI instead.

What's left do to here?

  • Needs rebase on top of master
  • Unit tests
  • Rename config.infura to config.rpcProvider
  • If we want to support Infura Secrets we should use project ID instead of endpoint. I'd probably get rid of all mentions of infura for now.

Closes #14

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2021

🦋 Changeset detected

Latest commit: 9fe200d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@dethcrypto/eth-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hasparus hasparus changed the title follow proxies Follow Proxies Nov 10, 2021
@hasparus hasparus marked this pull request as ready for review November 10, 2021 13:17
Copy link
Member

@krzkaczor krzkaczor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

Copy link
Member

@krzkaczor krzkaczor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs readme updates:

  • note about new rpcProvider option
  • note about this feature

- [Examples](#examples)
- [Videos](#videos)
- [Videos](#videos)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Markdown All in One extension for VSCode which updates the TOC automatically.

@hasparus hasparus merged commit d92585b into master Nov 12, 2021
@hasparus hasparus deleted the follow-proxies branch November 12, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically follow proxies
2 participants