This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Basic BitId support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guywillett
previously approved these changes
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This pull request adds support for the BitID protocol
Issue: #4
Dependencies: No dependencies
Testing instructions: Will add later
Merge checklist:
Author concerns:
At the moment the intention is to have a working prototype for the support for this authentication protocol, that we could later iterate on and improve.
At the moment (this pull request), the external package used for specific bitcoin operations is unmaintained and very very old. It does not even support new address formats (Segwit). The idea is that once this feature is working correctly on our side, we could replace the
pybitidlibrary with a new one that is better maintained or even implement it correctly in this package.