Add support for fullscreen + never grab mouse + resize window #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madebr
changed the title
|
nice, will try it out over the weekend! |
dethrace-labs
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only issue I have with the current implementation is that it does not preserve aspect ratio.
I tried the approach of this SO question, but the behavior is weird when going full screen and back. It also breaks when going full screen because it can resize the window to dimensions bigger then the screen size.
Instead, we probably just need to modify the gl renderer to draw its thing in the correct aspect ratio centrally and add black bars left and right. ==> This is what I ended up adding in this pr.
Fixes #72