Fix damage not being applied when hitting walls #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
dethrace-labs
commented
Sep 16, 2022
•
dethrace-labs
commented
- This was a regression caused by incorrect refactoring (by me in Implements "noncar" physics #122)
- Fixes Car is not damaged by collisions with walls #157
madebr
approved these changes
Sep 16, 2022
| @@ -18,7 +18,8 @@ else() | |||
| include(GetGitRevisionDescription) | |||
| git_describe(DETHRACE_VERSION) | |||
| endif() | |||
| message(STATUS "DethRace version ${DETHRACE_VERSION}") | |||
|
|
|||
| message(STATUS "dethrace version ${DETHRACE_VERSION}") | |||
There was a problem hiding this comment.
Just a reminder if you ever decide to create a new dethrace release, to not forget to include a VERSION file in the source release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.