Fixes + add TestAutoSpecialVolume (=underwater) #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pack demo has smk, xmas demo has a flic)
| @@ -1795,7 +1795,11 @@ void LoadCar(char* pCar_name, tDriver pDriver, tCar_spec* pCar_spec, int pOwner, | |||
| FatalError(kFatalError_FileCorrupt_S, pCar_name); | |||
| } | |||
| if (*pDriver_name != '\0') { | |||
| #if defined(DETHRACE_FIX_BUGS) | |||
There was a problem hiding this comment.
could you add a comment documenting what the bug is that we are fixing?
| for (i = 0; i < len; i++) { | ||
| c = pS[i]; | ||
| #if defined(DETHRACE_FIX_BUGS) |
There was a problem hiding this comment.
add a comment documenting the original bug behavior?
There was a problem hiding this comment.
The OG game (carm95.exe at least) does not do this.
It keeps the original key and does not decode the comments with the alternative key.
I'll add this as a comment.
There was a problem hiding this comment.
that would be great, thanks.
| if (gEncryption_method == 1) { | ||
| if (c == '\t') { | ||
| c = 0x80; | ||
| c = 0x9f; |
There was a problem hiding this comment.
hmm, good spotting. Dont know how I got encryption methods round the wrong way! 🤔
… a bug" This reverts commit 3345649.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrXXXfunctions/macro'sDecodeLine2+tools/decode_datatxt.pyso the coments become readableStopGroovidelicFixes No difference in handling underwater #194
DrawTheGlow.This change might be a bit controversial as it might introduces more crashes.
But I think this is good so we can find the bug sooner.
Either case, the crash in
SmokeLinehappens on my system too with stubbing this function.--full-screencommand line option to start DethRace in full screen modeFixes Cursor position scaled incorrectly in
-hiresmode #218IWANTTOFIDDLE. Tested with Carmageddon 1 full game data by encoding/decoding the data a few times.