Fix gear rendering for Suppressor #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dethrace-labs
approved these changes
Dec 3, 2022
|
Maybe you could change the “>> 3” to a “/ 8” since you are touching those lines? It’s more likely that was what the original code looked like |
Fix misaligned gear mask and a buffer overflow for cars which use more than 8 gears, and thus pixelmaps other than HGEARS.PIX. Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
zear
force-pushed
the
fix_gear_rendering
branch
from
c214488
to
bb41b81
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix misaligned gear mask and a buffer overflow for cars which use more than 8 gears, and thus pixelmaps other than HGEARS.PIX.
This issue exists because the gear rendering code assumes that the pixelmap with gear images contains 8 individual gear images. However, this is only true for HGEARS.PIX. In case of the Suppressor, which uses HGEARS4.PIX, there are 11 gears and so the mask is applied at the wrong offset.
Since both of the pixelmaps in question have gears that should clip at the height of 28, hardcode this number instead of trying to calculate it.
Another solution would be to simply force HGEARS4.PIX for all the cars, as those graphics are identical for both files (just with more gears in the latter one). I guess they really wanted to save every byte of memory in the OG, huh?
This fixes #256:
