Fix time credit headup #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the previous time credit in `gLast_time_credit_amount` instead of `gLast_time_credit_headup`. The latter is supposed to hold the headup slot number and gets overwritten with time unrelated values. Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
|
Nice find. Did you check the other references to gLast_time_credit_headup and gLast_time_credit_amount to make sure they aren’t transposed in other places? |
dethrace-labs
approved these changes
Dec 3, 2022
|
Yes, |
madebr
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the previous time credit in
gLast_time_credit_amountinstead ofgLast_time_credit_headup. The latter is supposed to hold the headup slot number and gets overwritten withNewTextHeadupSlotindex, effectively capping the time credits at the value of+13.This fixes #182.