SmackerLib API #303
Merged
SmackerLib API #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madebr
reviewed
Apr 18, 2023
| @@ -59,21 +59,13 @@ void PlaySmackerFile(char* pSmack_name) { | |||
| tPath_name the_path; | |||
| br_colour* br_colours_ptr; | |||
| tU8* smack_colours_ptr; | |||
| // Smack* smk; | |||
There was a problem hiding this comment.
FYI, I was able to reverse the logic for carmageddon 2: https://github.com/madebr/rec2/blob/master/src/carma2/common/cutscene.c
There was a problem hiding this comment.
awesome. So much similarity. I'm sad they got rid of the fuck_off variable :P
There was a problem hiding this comment.
nevermind, I forgot you have to make up your own names. Well, probably what you have as keyPressed is really still fuck_off in the OG code! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a small shim exposing the RAD Smacker API to
dethraceso we can keep the code incutscene.cas original as possible.libsmacker is now only a hidden dependency of smackw32