Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes missing fatal error messages #316

Merged
merged 3 commits into from
May 2, 2023
Merged

Fixes missing fatal error messages #316

merged 3 commits into from
May 2, 2023

Conversation

dethrace-labs
Copy link
Owner

@dethrace-labs dethrace-labs commented May 1, 2023 •
edited
Loading

Error messages are now piped to stderr and the sdl_opengl platform also renders an SDL message box

Screenshot 2023-05-02 at 6 47 51 am

Fixes #312

@dethrace-labs dethrace-labs requested a review from madebr May 1, 2023 20:06
madebr
madebr approved these changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@madebr madebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Linux as well.

image

@dethrace-labs
Copy link
Owner Author

Isn't SDL lovely? :)

@dethrace-labs dethrace-labs merged commit c90f24d into main May 2, 2023
@dethrace-labs dethrace-labs deleted the fix_312 branch May 2, 2023 01:01
@dethrace-labs dethrace-labs mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madebr madebr madebr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error reporting when no game data is found
2 participants
@dethrace-labs @madebr