Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes stack traces on osx #337

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fixes stack traces on osx #337

merged 1 commit into from
Jul 6, 2023

Conversation

dethrace-labs
Copy link
Owner

@dethrace-labs dethrace-labs commented Jul 5, 2023

Stack traces work again with position independent code enabled.

******************
Caught SIGSEGV
******************

Stack trace:
0: GetALineAndDontArgue (in dethrace) (utility.c:325)
1: GetAFloat (in dethrace) (loading.c:2886)
2: LoadGeneralParameters (in dethrace) (loading.c:379)
3: InitialiseApplication (in dethrace) (init.c:356)
4: InitialiseDeathRace (in dethrace) (init.c:419)
5: GameMain (in dethrace) (main.c:123)
6: original_main (in dethrace) (win95sys.c:949)
7: main (in dethrace) (main.c:34)

inspired by https://github.com/mysql/mysql-server/blob/ea7087d885006918ad54458e7aad215b1650312c/storage/ndb/src/common/portlib/ndb_stacktrace.cpp#L76

Fixes #197

@dethrace-labs dethrace-labs merged commit 80f1a88 into main Jul 6, 2023
5 checks passed
@dethrace-labs dethrace-labs deleted the fix_macos_stacktraces branch July 6, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.4.0 binaries do not print symbol locations in stacktrace when failing
1 participant