Various work for upstream #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimming the rectangles for the HUD is not working, because the renderer needs to write back to the back screen.
madebr
commented
Feb 22, 2022
madebr
commented
Feb 22, 2022
| @@ -178,6 +178,7 @@ int DRSceneRayPick2D(br_actor* world, br_vector3* pPosition, br_vector3* pDir, d | |||
| LOG_TRACE("(%p, %p, %p, %p)", world, pPosition, pDir, callback); | |||
|
|
|||
| BrMatrix34Inverse(&gPick_model_to_view__finteray, &world->t.t.mat); | |||
| LOG_WARN_ONCE("Missing material and model pointers to ActorRayPick2D"); | |||
There was a problem hiding this comment.
Whats the purpose of the warning here? These params are used as defaults and are always deliberately set to null
There was a problem hiding this comment.
I think this function is called with a material and model pointer, but I don't know what one and how it is used.
At least, it's not NULL.
| @@ -608,6 +610,7 @@ void InitRace() { | |||
| InitPlayers(); | |||
| if (gNet_mode) { | |||
| gProgram_state.credits_earned = gInitial_net_credits[gCurrent_net_game->options.starting_money_index]; | |||
| InitNetGameplayStuff(); | |||
|
Amazing work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brender changes:
brender.h, such that dethrace may use it.br_size_tfromuint32_ttosize_t.br_types.hby value, instead of by name.BR_ASIZEandCOUNT_OFin various places instead of hardcoding magic valuesdethrace changes:
WARN_ONCEmacro to avoid spamvarious:
tools/progress.py, by ordering on name it becomes easy to diff progresstools/decode_datatxt.py)plus many other changes
The big bump in percentage is due to implementing many little functions in
powerup.candpmnull.c+ others.TBH, this percentage says nothing about real progress.