-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truckload of updates #96
Conversation
…ix bugs/compiler warnings
…rning about number formatting
…erent wall texturing levels
… a debugger to attach
While this is awesome work, as usual(!), this kind of PR is a little difficult for me to handle. PRs that implement a feature or behavior end-to-end are easier to This PR has some things that should be easy to merge:
Things that I don't mind as extras in the PR:
Things that make it hard to merge:
I'm torn, because I see all your good work, but I want to get into the habit of merging full features without so much random extras |
if (i < 0 || pTrack_spec->ampersand_digits <= i) { | ||
return 1; | ||
} | ||
r1 = BR_SQR3(pActor->t.t.mat.m[0][0], pActor->t.t.mat.m[0][1], pActor->t.t.mat.m[0][2]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I normally use BrVector3LengthSquared
here - probably BR_SQR3
could be removed from the public brender include
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this one because I found it weird to cast a row of a matrix to a vector, but it makes sense to do it.
So I'll do that from now on.
Going to merge this now |
Highlights:
I don't guarantee any compatibility with the original carmageddon savegames.
So create a backup before using it, is advised...