Update based on comments of EthanG and DavidB

[vb-balazs]

Update based on the comments of Ethan Grossman (01.10) and David Black (04.10).

[louberger]

This sentence isn't quit right for IP. How about:

DetNet uses header information to perform traffic classification, i.e., identify DetNet flows, and provide DetNet service and forwarding functions. As mentioned above, DetNet may add headers, as is the case for DN MPLS, or may headers that are already present, as is the case in DN IP.

[vb-balazs]

OK. Agree with proposed change.

[EthanGrossman]

Typo at "or may headers", I assume s/b "or may use headers".

[agmalis]

I agree with Lou, it's a well-known and deployed example. I'm not sure why it was removed. Cheers, Andy

…

On Tue, Oct 22, 2019 at 9:22 AM Lou Berger ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In data-plane-framework/draft-ietf-detnet-data-plane-framework.xml <#55 (comment)> : > - Data plane technology: The DetNet data plane is provided by the DetNet - service and forwarding sub layers. The DetNet service sub-layer I think the sentence "The DetNet data plane is provided by the DetNet service and forwarding sub layers. " Should not be dropped, suggest adding back as the frst sentence in the new section. ------------------------------ In data-plane-framework/draft-ietf-detnet-data-plane-framework.xml <#55 (comment)> : > <t> - Encapsulation format: DetNet encodes specific flow attributes - (namely flow identity and sequence number) in packets. + DetNet encodes specific flow attributes + (flow identity and sequence number) in packets. For example, in DetNet IP, zero encapsulation may be used and no sequence number suggest, s/may be/is ------------------------------ In data-plane-framework/draft-ietf-detnet-data-plane-framework.xml <#55 (comment)> : > - +-------+ +---------+ - | DN IP | | DN MPLS | - +-------+ +---------+ + <section title="Encapsulation" anchor="sec_dp_encap"> + <t> + The encapsulation of a DetNet flow allows it to be sent over a + data plane technology other than its native type. For example, + an Ethernet TSN app flow can be sent as a DetNet app flow over MPLS. This sentence isn't quit right for IP. How about: DetNet uses header information to perform traffic classification, i.e., identify DetNet flows, and provide DetNet service and forwarding functions. As mentioned above, DetNet may add headers, as is the case for DN MPLS, or may headers that are already present, as is the case in DN IP. ------------------------------ In data-plane-framework/draft-ietf-detnet-data-plane-framework.xml <#55 (comment)> : > @@ -340,16 +333,18 @@ </list> </t> <t> - Both of these metadata are required for DetNet service - sub-layer specific functions (e.g., PREOF). DetNet forwarding - sub-layer related functions require only Flow-ID. - </t> - <t> - Metadata can be a useful way of identifying packets that need to be - treated as a flow or flow aggregate. It is also useful as a way of - including a sequence number the packet for use by the PREOF function - or as a place to carry OAM indications or OAM information to - instrument DetNet data plane operation. + The DetNet data plane supports a Flow-ID (for identification of the s/data plane/data plane framework ------------------------------ In data-plane-framework/draft-ietf-detnet-data-plane-framework.xml <#55 (comment)> : > Reservation of resources can allocate resources to specific DetNet - flows. This can eliminate packet contention and loss for DetNet - traffic. This also can reduce jitter for the DetNet traffic. DetNet - flows are assumed to behave with respect to the reserved traffic - profile. If other traffic shares the link resources, the use of + flows. This can eliminate packet contention and packet loss for DetNet + traffic. This also can reduce jitter for DetNet traffic. So, resources s/So, r/R ------------------------------ In data-plane-framework/draft-ietf-detnet-data-plane-framework.xml <#55 (comment)> : > @@ -885,11 +893,10 @@ Sub-Network | L2 | | TSN | | UDP | <section title="Flow Aggregation Control"> <t> - Flow aggregation includes aggregation accomplished through the use of - hierarchical LSPs in MPLS and tunnels, in the case of IP, MPLS and TSN, - all of which aggregate multiple DetNet flows into a single new DetNet - flow. Aggregation can also be grouping of IP flows that share - 6-tuple attributes or flow identifiers at the DetNet sub-layer. + Flow aggregation means that multiple App-flows are served by a single new DetNet + flow. There are many techniques to achieve aggregation, for example in case of IP, + it can be grouping of IP flows that share 6-tuple attributes or flow + identifiers at the DetNet sub-layer. Why drop the MPLS example that are very familiar to some. Suggest adding back: Another example includes aggregation accomplished through the use of hierarchical LSPs in MPLS and tunnels. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#55?email_source=notifications&email_token=ACIKQKNJQ336O5WNS6E3DODQP35CRA5CNFSM4I743R2KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIYM63Y#pullrequestreview-305188719>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACIKQKPUIUCWPZR53SHDRL3QP35CRANCNFSM4I743R2A> .

[louberger]

comments have been resolved